Fix zero-dimensional cone in cones in PolyhedralGeometry
#4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlorenz
reviewed
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4336 +/- ##
=======================================
Coverage 84.50% 84.50%
=======================================
Files 644 645 +1
Lines 85606 85624 +18
=======================================
+ Hits 72339 72357 +18
Misses 13267 13267
|
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
lgoettgens
added
the
topic: polyhedral geometry
benlorenz
approved these changes
Nov 21, 2024
benlorenz
pushed a commit
that referenced
this pull request
Dec 12, 2024
Merged
benlorenz
added a commit
that referenced
this pull request
Dec 13, 2024
Backports for release 1.2.2: fix galois_group problem. #4396 Fix zero-dimensional cone in cones in PolyhedralGeometry #4336 Fix up generic characteristic method for localized rings. #4346 test/PolyhedralGeometry: remove some prefer blocks #4351 Add comment about bibtool version, minor fix in testsuite #4356 Add hash method for RayVector #4354 Fix indent in AlgebraicCycles.md #4368 Fix toric typo #4367
HereAround
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By Definition 1.2.1 in
[CLS11](@cite), the set {0} is a cone.The function
cones(X, 0)now returns an iterator that returns the zero-dimensional cone, provided the lineality space has length zero, fixing a bug.If
nis negative, thencones(X, n)now returns an empty iterator, fixing the type instability.