Fix regression in galois_group
#4396
Merged
+53
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous last fix changed the order in which the factors were processed - this broke unfortunately that part in the end that adds the multiplicity back in. The current version is not perfect (unneccessary computations are done) but fixes the problem
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4396 +/- ##
==========================================
+ Coverage 84.38% 84.40% +0.01%
==========================================
Files 656 656
Lines 87198 87214 +16
==========================================
+ Hits 73583 73609 +26
+ Misses 13615 13605 -10
|
|
@fieker Thanks for addressing this quickly. Ideally, after the merge, we could produce a v1.2.2 with this patch. |
thofma
approved these changes
Dec 11, 2024
|
@benlorenz could you do initiate the steps for v1.2.2? |
benlorenz
pushed a commit
that referenced
this pull request
Dec 11, 2024
The previous last fix changed the order in which the factors were processed - this broke unfortunately that part in the end that adds the multiplicity back in. The current version is not perfect (unneccessary computations are done) but fixes the problem (cherry picked from commit 50b081e)
Merged
benlorenz
added a commit
that referenced
this pull request
Dec 13, 2024
Backports for release 1.2.2: fix galois_group problem. #4396 Fix zero-dimensional cone in cones in PolyhedralGeometry #4336 Fix up generic characteristic method for localized rings. #4346 test/PolyhedralGeometry: remove some prefer blocks #4351 Add comment about bibtool version, minor fix in testsuite #4356 Add hash method for RayVector #4354 Fix indent in AlgebraicCycles.md #4368 Fix toric typo #4367
fingolfin
changed the title
galois_group
fingolfin
added
the
release notes: use title
thofma
changed the title
galois_groupgalois_group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous last fix changed the order in which the factors were processed - this broke unfortunately that part in the end that adds the multiplicity back in.
The current version is not perfect (unneccessary computations are done) but fixes the problem