Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backports 1.2.2 #4397

Merged
merged 10 commits into from
Dec 13, 2024
Merged

backports 1.2.2 #4397

merged 10 commits into from
Dec 13, 2024

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Dec 11, 2024 •
edited
Loading

fieker and others added 2 commits December 11, 2024 21:02
@fieker @benlorenz
fix galois_group problem. (#4396)
60b0e9e 
The previous last fix changed the order in which the factors
were processed - this broke unfortunately that part in the end
that adds the multiplicity back in.

The current version is not perfect (unneccessary computations are done)
but fixes the problem

(cherry picked from commit 50b081e)
@benlorenz
Version 1.2.2
3bb7907
@lgoettgens

This comment was marked as resolved.

Sign in to view
paemurru and others added 8 commits December 13, 2024 00:21
@paemurru @benlorenz
Fix zero-dimensional cone in cones (#4336)
12dda0e 
(cherry picked from commit 23716cc)
(cherry picked from commit 0bdde45)
(cherry picked from commit 6045366)
(cherry picked from commit 4c2f909)
(cherry picked from commit 5955eaa)
(cherry picked from commit 53ad859)
@HechtiDerLachs @benlorenz
Fix up generic characteristic method for localized rings. (#4346)
5203c0c 
(cherry picked from commit f849adc)
@benlorenz
test/PolyhedralGeometry: remove some prefer blocks (#4351)
3d79de5 
even though these should be scoped, they do seem to have some side-effects
they should not really be necessary so try removing them

(cherry picked from commit 4542bd3)
@lkastner @benlorenz
DevDocs: Comment on bibtool version (#4356)
09cf374 
(cherry picked from commit 9348958)
@lkastner @benlorenz
ToricVarieties: Fix test that got confused and selected the wrong var…
8274820 
…iables (#4356)

(cherry picked from commit 5d4b919)
@alexej-jordan @benlorenz
Add hash method for RayVector (#4354)
6317332 
* added hash method for RayVector; fixed wrong test

* add isequal and corresponding test for RayVector

(cherry picked from commit f83a525)
@paemurru @benlorenz
Fix indent in AlgebraicCycles.md (#4368)
c146d28 
* Fix indent in AlgebraicCycles.md

It looks correct on GitHub but is incorrect in https://docs.oscar-system.org/dev/AlgebraicGeometry/ToricVarieties/AlgebraicCycles/

* Update AlgebraicCycles.md

(cherry picked from commit 278b79d)
@paemurru @benlorenz
Fix toric typo (#4367)
958b412 
Reword awkward toric docstring.

(cherry picked from commit 5aec608)
@benlorenz

This comment was marked as resolved.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (357fd97) to head (958b412).
Report is 11 commits behind head on release-1.2.

Files with missing lines Patch % Lines
src/Rings/localization_interface.jl 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.2    #4397      +/-   ##
===============================================
+ Coverage        84.63%   84.65%   +0.01%     
===============================================
  Files              641      641              
  Lines            85144    85169      +25     
===============================================
+ Hits             72062    72096      +34     
+ Misses           13082    13073       -9
Files with missing lines Coverage Δ
...oricVarieties/NormalToricVarieties/constructors.jl 100.00% <ø> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 79.50% <100.00%> (+0.88%) ⬆️
src/PolyhedralGeometry/PolyhedralFan/properties.jl 98.41% <100.00%> (+0.07%) ⬆️
src/PolyhedralGeometry/iterators.jl 92.13% <100.00%> (+0.08%) ⬆️
src/Rings/localization_interface.jl 60.84% <80.00%> (+0.30%) ⬆️

@benlorenz benlorenz marked this pull request as ready for review December 13, 2024 18:38
@benlorenz benlorenz merged commit 11820e4 into release-1.2 Dec 13, 2024
30 of 31 checks passed
@benlorenz benlorenz deleted the backports-release-1.2 branch December 13, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@benlorenz @lgoettgens @fieker @paemurru @HechtiDerLachs @lkastner @alexej-jordan