Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-localized stablecoin type #1011

Closed
gfant opened this issue Nov 15, 2022 · 2 comments · Fixed by #1025
Closed

Non-localized stablecoin type #1011

gfant opened this issue Nov 15, 2022 · 2 comments · Fixed by #1025

Comments

@gfant
Copy link
Contributor

gfant commented Nov 15, 2022

When you add one asset for liquidity to a pool that involves a stable coin, the last word is called from the variable {mechanism}, forcing it to be in English.

image

In a same LP view, you can notice the word "Unbounded" isn't affected by the translation.
image

Also when you go to a LP and Bond Liquidity, there are words that aren't translated.
image

@jonator jonator changed the title Localisation error in all languages Non-localized stablecoin type Nov 15, 2022
@jonator
Copy link
Member

jonator commented Nov 15, 2022

The collateral type should instead be used as a key into the respective localization json file

jonator pushed a commit that referenced this issue Nov 20, 2022
* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice
jonator added a commit that referenced this issue Nov 25, 2022
* Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens)

* Update SIENNA's image

* Update ALTER's image

* Add Button group token

* added SHD, BUTT, & ALTER svgs

* added staking derivatives

* added ics20 contract to ibc-assets

* updated to channel-476

* updated ics20 contract

* removed accidental changes

* fix comment

* stkd-SCRT

* cleanup

* Update ibc-assets.ts

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Fix content overflow on zh-tw (#1024)

* Fix #1011 Non-localized stablecoin type (#1025)

* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

* Switch to CoinGecko IDs--no pool spot prices (#1026)

* Fix content overflow on zh-tw (#1028)

* Fix content overflow on zh-tw

* Fix content overflow on languages with Unicode/full width chars

* Add missing entry

* correct stargaze cgid, uncomment prices

* add ibc-go to chihuahua

* add secret network features and change api

* minor fix

* add secret network tokens

* Use `computedFn`

* Don't get prices when no input in swap tool

* Enable pool calculation

* update korean.json (#1037)

* Uncomment image

* removed duplicated secret network tokens

* Update Chihuahua Chain Suggest Fees

* Replace FUND token logo with Circular logo

Was a square before.

* Change crbruc to unstable, unverified (#1040)

* Fix pool reward query error response

* Changed Marble to unverified (#1045)

Unverified because Marble no longer receives incentives.

* Fix zh-tw format (#1043)

* Fix Docker GitHub Actions  (#1044)

* Fix commands in README.md

* Remove arm64 support

* Pin node version to 18.12.1

* Remove duplicate Dockerfile and docker-compose.yml

* Make NETA, BOOT unverified

* Changed IXO to unverified (#1049)

* Changed Marble to unverified

Unverified because Marble no longer receives incentives.

* Changed IXO to unverified

Unverified because IXO no longer receives incentives.

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

Co-authored-by: Assaf Morami <assaf.morami@gmail.com>
Co-authored-by: DrPresident <jacksonswenson@securesecrets.org>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Co-authored-by: Sehyun Chung ✌︎ <sehyun@berkeley.edu>
Co-authored-by: JeremyParish69 <95667791+JeremyParish69@users.noreply.github.com>
Co-authored-by: Jeremy Parish <jeremyparish69@gmail.com>
Co-authored-by: jonator <jonathanator0@gmail.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: Crypto Assassin <103904125+CryptoAssassin1@users.noreply.github.com>
Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
@gfant
Copy link
Contributor Author

gfant commented Nov 29, 2022

I guess the issue continue but now in another format.

image

JoseRFelix pushed a commit that referenced this issue Dec 5, 2022
* Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens)

* Update SIENNA's image

* Update ALTER's image

* Add Button group token

* added SHD, BUTT, & ALTER svgs

* added staking derivatives

* added ics20 contract to ibc-assets

* updated to channel-476

* updated ics20 contract

* removed accidental changes

* fix comment

* stkd-SCRT

* cleanup

* Update ibc-assets.ts

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Fix content overflow on zh-tw (#1024)

* Fix #1011 Non-localized stablecoin type (#1025)

* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

* Switch to CoinGecko IDs--no pool spot prices (#1026)

* Fix content overflow on zh-tw (#1028)

* Fix content overflow on zh-tw

* Fix content overflow on languages with Unicode/full width chars

* Add missing entry

* correct stargaze cgid, uncomment prices

* add ibc-go to chihuahua

* add secret network features and change api

* minor fix

* add secret network tokens

* Use `computedFn`

* Don't get prices when no input in swap tool

* Enable pool calculation

* update korean.json (#1037)

* Uncomment image

* removed duplicated secret network tokens

* Update Chihuahua Chain Suggest Fees

* Replace FUND token logo with Circular logo

Was a square before.

* Change crbruc to unstable, unverified (#1040)

* Fix pool reward query error response

* Changed Marble to unverified (#1045)

Unverified because Marble no longer receives incentives.

* Fix zh-tw format (#1043)

* Fix Docker GitHub Actions  (#1044)

* Fix commands in README.md

* Remove arm64 support

* Pin node version to 18.12.1

* Remove duplicate Dockerfile and docker-compose.yml

* Make NETA, BOOT unverified

* Changed IXO to unverified (#1049)

* Changed Marble to unverified

Unverified because Marble no longer receives incentives.

* Changed IXO to unverified

Unverified because IXO no longer receives incentives.

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

Co-authored-by: Assaf Morami <assaf.morami@gmail.com>
Co-authored-by: DrPresident <jacksonswenson@securesecrets.org>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Co-authored-by: Sehyun Chung ✌︎ <sehyun@berkeley.edu>
Co-authored-by: JeremyParish69 <95667791+JeremyParish69@users.noreply.github.com>
Co-authored-by: Jeremy Parish <jeremyparish69@gmail.com>
Co-authored-by: jonator <jonathanator0@gmail.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: Crypto Assassin <103904125+CryptoAssassin1@users.noreply.github.com>
Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants