Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1011 Non-localized stablecoin type #1025

Merged
merged 3 commits into from
Nov 20, 2022
Merged

Conversation

sehyunc
Copy link
Contributor

@sehyunc sehyunc commented Nov 20, 2022

Fix #1011 Non-localized stablecoin type
add-liquidity.tsx

  • use collateral type to key into localization file

dayjs-locale-es.js

  • update to Day.js locale object as detailed in docs

dayjs-locale-ko.js

  • same as above

es.json

  • add stablecoin type translation

_app.tsx

  • set locale object for day.js localization as detailed in docs

Would like a sanity check that this is the way to go for the above solutions. If so, I can update all the localization json specific to day.js, but will need additional translations for stablecoin types to add to general localization files.

Could not replicate bug of "Unbonded" not being translated, although it's wrapping in certain languages.
Screenshot 2022-11-19 at 6 56 59 PM

@vercel
Copy link

vercel bot commented Nov 20, 2022

@sehyunc is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

@sehyunc
Copy link
Contributor Author

sehyunc commented Nov 20, 2022

also included fix for a key error in the Connect Wallet Modal
Screenshot 2022-11-19 at 7 53 24 PM

Copy link
Member

@jonator jonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the various cleanups. LGTM

@@ -41,7 +41,7 @@ export const KeplrConnectionSelectModal: FunctionComponent<
/>
<div className="flex flex-col text-left ml-5">
<div className="flex items-center gap-2">
<h6>{t("installKeplr")}</h6>
<h6>{t("keplr.install")}</h6>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@vercel
Copy link

vercel bot commented Nov 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osmosis-frontend ✅ Ready (Inspect) Visit Preview Nov 20, 2022 at 6:07PM (UTC)

@jonator jonator merged commit 938c10b into osmosis-labs:master Nov 20, 2022
@gnujoow
Copy link
Contributor

gnujoow commented Nov 22, 2022

👍

jonator added a commit that referenced this pull request Nov 25, 2022
* Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens)

* Update SIENNA's image

* Update ALTER's image

* Add Button group token

* added SHD, BUTT, & ALTER svgs

* added staking derivatives

* added ics20 contract to ibc-assets

* updated to channel-476

* updated ics20 contract

* removed accidental changes

* fix comment

* stkd-SCRT

* cleanup

* Update ibc-assets.ts

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Fix content overflow on zh-tw (#1024)

* Fix #1011 Non-localized stablecoin type (#1025)

* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

* Switch to CoinGecko IDs--no pool spot prices (#1026)

* Fix content overflow on zh-tw (#1028)

* Fix content overflow on zh-tw

* Fix content overflow on languages with Unicode/full width chars

* Add missing entry

* correct stargaze cgid, uncomment prices

* add ibc-go to chihuahua

* add secret network features and change api

* minor fix

* add secret network tokens

* Use `computedFn`

* Don't get prices when no input in swap tool

* Enable pool calculation

* update korean.json (#1037)

* Uncomment image

* removed duplicated secret network tokens

* Update Chihuahua Chain Suggest Fees

* Replace FUND token logo with Circular logo

Was a square before.

* Change crbruc to unstable, unverified (#1040)

* Fix pool reward query error response

* Changed Marble to unverified (#1045)

Unverified because Marble no longer receives incentives.

* Fix zh-tw format (#1043)

* Fix Docker GitHub Actions  (#1044)

* Fix commands in README.md

* Remove arm64 support

* Pin node version to 18.12.1

* Remove duplicate Dockerfile and docker-compose.yml

* Make NETA, BOOT unverified

* Changed IXO to unverified (#1049)

* Changed Marble to unverified

Unverified because Marble no longer receives incentives.

* Changed IXO to unverified

Unverified because IXO no longer receives incentives.

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

Co-authored-by: Assaf Morami <assaf.morami@gmail.com>
Co-authored-by: DrPresident <jacksonswenson@securesecrets.org>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Co-authored-by: Sehyun Chung ✌︎ <sehyun@berkeley.edu>
Co-authored-by: JeremyParish69 <95667791+JeremyParish69@users.noreply.github.com>
Co-authored-by: Jeremy Parish <jeremyparish69@gmail.com>
Co-authored-by: jonator <jonathanator0@gmail.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: Crypto Assassin <103904125+CryptoAssassin1@users.noreply.github.com>
Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
JoseRFelix pushed a commit that referenced this pull request Dec 5, 2022
* Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens)

* Update SIENNA's image

* Update ALTER's image

* Add Button group token

* added SHD, BUTT, & ALTER svgs

* added staking derivatives

* added ics20 contract to ibc-assets

* updated to channel-476

* updated ics20 contract

* removed accidental changes

* fix comment

* stkd-SCRT

* cleanup

* Update ibc-assets.ts

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Fix content overflow on zh-tw (#1024)

* Fix #1011 Non-localized stablecoin type (#1025)

* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

* Switch to CoinGecko IDs--no pool spot prices (#1026)

* Fix content overflow on zh-tw (#1028)

* Fix content overflow on zh-tw

* Fix content overflow on languages with Unicode/full width chars

* Add missing entry

* correct stargaze cgid, uncomment prices

* add ibc-go to chihuahua

* add secret network features and change api

* minor fix

* add secret network tokens

* Use `computedFn`

* Don't get prices when no input in swap tool

* Enable pool calculation

* update korean.json (#1037)

* Uncomment image

* removed duplicated secret network tokens

* Update Chihuahua Chain Suggest Fees

* Replace FUND token logo with Circular logo

Was a square before.

* Change crbruc to unstable, unverified (#1040)

* Fix pool reward query error response

* Changed Marble to unverified (#1045)

Unverified because Marble no longer receives incentives.

* Fix zh-tw format (#1043)

* Fix Docker GitHub Actions  (#1044)

* Fix commands in README.md

* Remove arm64 support

* Pin node version to 18.12.1

* Remove duplicate Dockerfile and docker-compose.yml

* Make NETA, BOOT unverified

* Changed IXO to unverified (#1049)

* Changed Marble to unverified

Unverified because Marble no longer receives incentives.

* Changed IXO to unverified

Unverified because IXO no longer receives incentives.

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

Co-authored-by: Assaf Morami <assaf.morami@gmail.com>
Co-authored-by: DrPresident <jacksonswenson@securesecrets.org>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Co-authored-by: Sehyun Chung ✌︎ <sehyun@berkeley.edu>
Co-authored-by: JeremyParish69 <95667791+JeremyParish69@users.noreply.github.com>
Co-authored-by: Jeremy Parish <jeremyparish69@gmail.com>
Co-authored-by: jonator <jonathanator0@gmail.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: Crypto Assassin <103904125+CryptoAssassin1@users.noreply.github.com>
Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-localized stablecoin type
3 participants