Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix content overflow on zh-tw #1028

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Fix content overflow on zh-tw #1028

merged 3 commits into from
Nov 21, 2022

Conversation

PikachuEXE
Copy link
Contributor

@PikachuEXE PikachuEXE commented Nov 21, 2022 •
edited
Loading

Before fix
image
image

After fix
image

@vercel
Copy link

vercel bot commented Nov 21, 2022

@PikachuEXE is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

@PikachuEXE
Copy link
Contributor Author

PikachuEXE commented Nov 21, 2022 •
edited
Loading

Note: Just added a commit to fix content overflow/text wrapping issue in any language with unicode/full width chars
Since for English only 1 word is in those sub containers, it works without whitespace-nowrap

e.g. zh-cn also has this issue on https://app.osmosis.zone/pool/553
image

@jonator jonator merged commit 5a09b28 into osmosis-labs:master Nov 21, 2022
@PikachuEXE PikachuEXE deleted the i18n/zh-tw branch November 22, 2022 00:17
jonator added a commit that referenced this pull request Nov 25, 2022
@milesz8 @assafmo
@DrPresident @PikachuEXE @sehyunc @JeremyParish69 @jonator @gnujoow @CryptoAssassin1 @niccoloraspa
Adds transfer status indicator to deposit withdraw (#1023)
0e78486 
* Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens)

* Update SIENNA's image

* Update ALTER's image

* Add Button group token

* added SHD, BUTT, & ALTER svgs

* added staking derivatives

* added ics20 contract to ibc-assets

* updated to channel-476

* updated ics20 contract

* removed accidental changes

* fix comment

* stkd-SCRT

* cleanup

* Update ibc-assets.ts

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Fix content overflow on zh-tw (#1024)

* Fix #1011 Non-localized stablecoin type (#1025)

* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

* Switch to CoinGecko IDs--no pool spot prices (#1026)

* Fix content overflow on zh-tw (#1028)

* Fix content overflow on zh-tw

* Fix content overflow on languages with Unicode/full width chars

* Add missing entry

* correct stargaze cgid, uncomment prices

* add ibc-go to chihuahua

* add secret network features and change api

* minor fix

* add secret network tokens

* Use `computedFn`

* Don't get prices when no input in swap tool

* Enable pool calculation

* update korean.json (#1037)

* Uncomment image

* removed duplicated secret network tokens

* Update Chihuahua Chain Suggest Fees

* Replace FUND token logo with Circular logo

Was a square before.

* Change crbruc to unstable, unverified (#1040)

* Fix pool reward query error response

* Changed Marble to unverified (#1045)

Unverified because Marble no longer receives incentives.

* Fix zh-tw format (#1043)

* Fix Docker GitHub Actions  (#1044)

* Fix commands in README.md

* Remove arm64 support

* Pin node version to 18.12.1

* Remove duplicate Dockerfile and docker-compose.yml

* Make NETA, BOOT unverified

* Changed IXO to unverified (#1049)

* Changed Marble to unverified

Unverified because Marble no longer receives incentives.

* Changed IXO to unverified

Unverified because IXO no longer receives incentives.

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

Co-authored-by: Assaf Morami <assaf.morami@gmail.com>
Co-authored-by: DrPresident <jacksonswenson@securesecrets.org>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Co-authored-by: Sehyun Chung ✌︎ <sehyun@berkeley.edu>
Co-authored-by: JeremyParish69 <95667791+JeremyParish69@users.noreply.github.com>
Co-authored-by: Jeremy Parish <jeremyparish69@gmail.com>
Co-authored-by: jonator <jonathanator0@gmail.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: Crypto Assassin <103904125+CryptoAssassin1@users.noreply.github.com>
Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
JoseRFelix pushed a commit that referenced this pull request Dec 5, 2022
@milesz8 @assafmo
@DrPresident @PikachuEXE @sehyunc @JeremyParish69 @jonator @gnujoow @CryptoAssassin1 @niccoloraspa @JoseRFelix
Adds transfer status indicator to deposit withdraw (#1023)
6b146a0 
* Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens)

* Update SIENNA's image

* Update ALTER's image

* Add Button group token

* added SHD, BUTT, & ALTER svgs

* added staking derivatives

* added ics20 contract to ibc-assets

* updated to channel-476

* updated ics20 contract

* removed accidental changes

* fix comment

* stkd-SCRT

* cleanup

* Update ibc-assets.ts

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Fix content overflow on zh-tw (#1024)

* Fix #1011 Non-localized stablecoin type (#1025)

* add sample fix for ko + es

* use collateral type as key into localization

* fix key for install keplr notice

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

* Switch to CoinGecko IDs--no pool spot prices (#1026)

* Fix content overflow on zh-tw (#1028)

* Fix content overflow on zh-tw

* Fix content overflow on languages with Unicode/full width chars

* Add missing entry

* correct stargaze cgid, uncomment prices

* add ibc-go to chihuahua

* add secret network features and change api

* minor fix

* add secret network tokens

* Use `computedFn`

* Don't get prices when no input in swap tool

* Enable pool calculation

* update korean.json (#1037)

* Uncomment image

* removed duplicated secret network tokens

* Update Chihuahua Chain Suggest Fees

* Replace FUND token logo with Circular logo

Was a square before.

* Change crbruc to unstable, unverified (#1040)

* Fix pool reward query error response

* Changed Marble to unverified (#1045)

Unverified because Marble no longer receives incentives.

* Fix zh-tw format (#1043)

* Fix Docker GitHub Actions  (#1044)

* Fix commands in README.md

* Remove arm64 support

* Pin node version to 18.12.1

* Remove duplicate Dockerfile and docker-compose.yml

* Make NETA, BOOT unverified

* Changed IXO to unverified (#1049)

* Changed Marble to unverified

Unverified because Marble no longer receives incentives.

* Changed IXO to unverified

Unverified because IXO no longer receives incentives.

* Adds transfer status indicator to deposit withdraw

* Revert some unneeded changes to package.json files

* Removes type that was put directly in observable query

* Remove unneeded type definition

* uses implied return undefined and spelling

* Remove unused store import

* Remove default baseUrl, Add in channel status logic

* Remove unused import and use deconstructed values directly

* Remove log

* Update button text for blocked and congested

Co-authored-by: Assaf Morami <assaf.morami@gmail.com>
Co-authored-by: DrPresident <jacksonswenson@securesecrets.org>
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
Co-authored-by: Sehyun Chung ✌︎ <sehyun@berkeley.edu>
Co-authored-by: JeremyParish69 <95667791+JeremyParish69@users.noreply.github.com>
Co-authored-by: Jeremy Parish <jeremyparish69@gmail.com>
Co-authored-by: jonator <jonathanator0@gmail.com>
Co-authored-by: KIM, WOOJUNG <gnujoow@users.noreply.github.com>
Co-authored-by: Crypto Assassin <103904125+CryptoAssassin1@users.noreply.github.com>
Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PikachuEXE @jonator