-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating binary json file #8698
Conversation
WalkthroughThe pull request introduces several updates to the Osmosis project, including a new entry in the CHANGELOG.md for a chore related to the Changes
Possibly related PRs
Tip OpenAI O1 model for chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
CHANGELOG.md (2)
Line range hint
4-4
: Address the TODO comment.Please add tests for this function as indicated by the TODO comment. Tests are important to ensure the function behaves as expected, especially after the parameter change.
Let me know if you need any help writing the tests. I'd be happy to assist!
Line range hint
12-24
: Reconsider the flat fee for discounted bills.The current logic applies a $20 service fee to all discounted bills, regardless of the discount amount. This can lead to situations where the "discounted" final bill is higher than the original amount, especially for the 10% discount tier.
For example:
- Original bill: $100
- After 10% discount: $90
- After $20 fee: $110
The $20 fee negates the discount and results in the customer paying more than the original amount.
Consider adjusting the fee structure or discount percentages to avoid this. Some options:
- Make the fee a percentage of the discounted amount instead of a flat fee.
- Increase the discount percentages to account for the flat fee.
- Only apply the fee if the discounted amount is above a certain threshold.
- Remove the fee entirely.
This will help ensure discounted bills are always lower than the original amount, so the discount feels meaningful to customers.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
networks/osmosis-1/upgrades/v26/mainnet/v26_binaries.json
is excluded by!**/*.json
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional comments not posted (1)
CHANGELOG.md (1)
Line range hint
1-2
: LGTM!The function logic is correct and the implementation is straightforward.
What is the purpose of the change
Adding binaries to network release file