Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating binary json file #8698

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Conversation

PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented Sep 12, 2024

What is the purpose of the change

Adding binaries to network release file

@PaddyMc PaddyMc added A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported labels Sep 12, 2024
Copy link
Contributor

coderabbitai bot commented Sep 13, 2024

Walkthrough

The pull request introduces several updates to the Osmosis project, including a new entry in the CHANGELOG.md for a chore related to the cosmwasm-optimizer and additional queries in the x/gauges module. The version has been updated to v26.0.0, which encompasses significant changes such as an upgrade to SDK v50 and Comet v0.38. Other modifications include performance improvements, configuration updates, and a fix for a smart account signing error.

Changes

File/Module Change Summary
CHANGELOG.md Updated to include a new entry for cosmwasm-optimizer (PR #8682) and additional queries in x/gauges (PR #8563). Removed previous entry for PR #8563 from "State Breaking" section. Version updated to v26.0.0.
x/gauges Added additional queries as part of changes in PR #8563.
app.toml New configurations added.
Performance calculations Improvements made in the calculation of exit CFMM shares.
Smart account signing Documented a fix for a signing check transaction error.

Possibly related PRs

Tip

OpenAI O1 model for chat
  • We have deployed OpenAI's latest O1 model for chat.
  • OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
  • Please share any feedback with us in the discussions post.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
CHANGELOG.md (2)

Line range hint 4-4: Address the TODO comment.

Please add tests for this function as indicated by the TODO comment. Tests are important to ensure the function behaves as expected, especially after the parameter change.

Let me know if you need any help writing the tests. I'd be happy to assist!


Line range hint 12-24: Reconsider the flat fee for discounted bills.

The current logic applies a $20 service fee to all discounted bills, regardless of the discount amount. This can lead to situations where the "discounted" final bill is higher than the original amount, especially for the 10% discount tier.

For example:

  • Original bill: $100
  • After 10% discount: $90
  • After $20 fee: $110

The $20 fee negates the discount and results in the customer paying more than the original amount.

Consider adjusting the fee structure or discount percentages to avoid this. Some options:

  1. Make the fee a percentage of the discounted amount instead of a flat fee.
  2. Increase the discount percentages to account for the flat fee.
  3. Only apply the fee if the discounted amount is above a certain threshold.
  4. Remove the fee entirely.

This will help ensure discounted bills are always lower than the original amount, so the discount feels meaningful to customers.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 235418b and fdcfe7e.

Files ignored due to path filters (1)
  • networks/osmosis-1/upgrades/v26/mainnet/v26_binaries.json is excluded by !**/*.json
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Additional comments not posted (1)
CHANGELOG.md (1)

Line range hint 1-2: LGTM!

The function logic is correct and the implementation is straightforward.

@PaddyMc PaddyMc merged commit 6caab9e into main Sep 13, 2024
1 check passed
@PaddyMc PaddyMc deleted the chore/add-binaries-to-release branch September 13, 2024 08:45
This was referenced Sep 27, 2024
@coderabbitai coderabbitai bot mentioned this pull request Nov 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants