fix concurrency issue in go test(x/lockup)

[mattverse]

Closes: #XXX

What is the purpose of the change

Additional changes that are required to prevent concurrency issue in addition to #8765

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

• Does this pull request introduce a new feature or user-facing behavior changes?
• Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

• Specification (x/{module}/README.md)
• Osmosis documentation site
• Code comments?
• N/A

[coderabbitai]

Walkthrough

The pull request includes updates to the CHANGELOG.md to document recent changes in the Osmosis project, categorizing them into "State Breaking," "Config," and "State Compatible" sections. It highlights significant updates related to the cosmwasm-optimizer and VM, as well as various fixes and enhancements. Additionally, a new test case, TestMarshalUnmarshalGenesis, has been added to the genesis_test.go file to ensure the correct handling of the genesis state during application initialization.

Changes

File Path	Change Summary
CHANGELOG.md	Updated to reflect recent changes; added entries under "Unreleased" for "State Breaking," "Config," and "State Compatible." Consolidated concurrency issue references.
x/lockup/keeper/genesis_test.go	Added TestMarshalUnmarshalGenesis test case to check marshalling/unmarshalling of genesis state; refactored to streamline test logic.

Possibly related PRs

• chore: changelog fixes #8423: This PR also updates the CHANGELOG.md, indicating a direct connection to the main PR's changes in the changelog.
• chore: updating binary json file #8698: This PR updates the CHANGELOG.md to reflect significant changes, including updates related to the cosmwasm-optimizer, which is mentioned in the main PR.
• fix concurrency issue in go test(x/lockup) #8765: This PR includes a changelog update that references a fix for a concurrency issue in the go test(x/lockup), which is also noted in the main PR's changelog updates.

Suggested reviewers

• czarcas7ic
• PaddyMc
• AlpinYukseloglu

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6c843fa and 0710d3d.

📒 Files selected for processing (2)

• CHANGELOG.md (1 hunks)
• x/lockup/keeper/genesis_test.go (0 hunks)

💤 Files with no reviewable changes (1)

• x/lockup/keeper/genesis_test.go

🧰 Additional context used

🔇 Additional comments (12)

CHANGELOG.md (12)

Line range hint 1-3: LGTM: Version number and title are clear.

The version number (v26.0.0) and title (Nitrogen) are clearly stated, which is good for identifying the release.

---

Line range hint 5-11: Comprehensive overview of the release contents.

The introduction provides a good summary of the major changes in this release, including new modules, API updates, and dependency changes. This helps users quickly understand the scope of the update.

---

Line range hint 13-36: State Breaking changes are well documented.

The State Breaking section clearly lists the changes that will affect the blockchain state. This is crucial information for node operators and developers. Some key points:

• New modules added (SuperCharged Liquidity, CosmWasm Pool)
• ProtoRev changes
• TokenFactory updates

---

Line range hint 38-43: Security update highlighted.

The security section mentions an important update to wasmvm in response to a security advisory. This is crucial information for users to be aware of.

---

Line range hint 45-61: Comprehensive list of new features.

The Features section provides a detailed list of new functionalities added in this release. This is valuable for users to understand what new capabilities are available.

---

Line range hint 63-87: API breaks are clearly documented.

The API breaks section is crucial for developers to understand what changes they need to make in their code. It's good to see a comprehensive list of changes with explanations.

---

Line range hint 89-101: State Breaking changes are well explained.

This section provides more details on the state breaking changes, which is important for node operators during the upgrade process.

---

Line range hint 103-107: Dependencies updates are listed.

It's good to see the dependency updates clearly stated, especially the upgrade to wasmd and the IBC cherry security patch.

---

Line range hint 109-132: Miscellaneous improvements are well documented.

This section provides a good overview of smaller changes and improvements that don't fit into the other categories. It's helpful for users to see the breadth of changes in the release.

---

Line range hint 134-138: Minor release changes are documented.

The v25.2.1 release notes provide information about logging changes and miscellaneous improvements. This is helpful for users to understand the scope of this minor release.

---

Line range hint 140-142: Logging improvement noted.

The addition of logging to track incentive accumulator truncation is a useful improvement for debugging and monitoring.

---

Line range hint 144-148: Miscellaneous improvements are listed.

The misc improvements section provides information about CLI changes and performance optimizations. These are valuable updates for users and operators.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.