Fix tests related to shininess #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in World::LoadModel currently creates an empty
link in models without links by calling GetElement("link")
without checking if such an element exists. This checks
HasElement("link") before calling GetElement, which fixes
a nested model test.
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The pr2 test was failing due to timeouts in the shininess service call. Move the call from Visual::Load to Visual::Init to allow the service advertisement in World::Load some time to take effect. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
@traversaro what does it take to use libsdformat 9.8.0 in condo-forge? |
|
the tests are all fixed in the jenkins ubuntu and homebrew builds, but condo-forge is failing due to a lack of libsdformat 9.8 |
We need to manually bump the v9 branch as unfortunately we do not have the autotick bot for non-default branches. I can do it in ~1 hour. |
Strange, apparently conda-forge should already contain 9.8, see https://anaconda.org/conda-forge/libsdformat and https://github.com/conda-forge/libsdformat-feedstock/blob/9bda5c89b3bf47bab6169bc7add488f4c710e336/recipe/meta.yaml#L2 . I need to check what is happening. |
|
I tried to play removing the pin from qt and to forge the installation of latest sdformat, but this happens: Probably there is some dependency that is not properly tracked in the pinned version in conda-forge, I will need to check a bit more. |
|
Ok, I was able to reproduce the problem locally. If I try to force the installation of a recent sdformat this happens: If I remove So the latest sdformat 9.8 was not build with urdfdom 3.1 . I can trigger a build to force this, but in the mean time you can just remove dartsim (that in any case is an optional dependency) from the dependencies installed. |
5 tasks
Workaround for an issue with libsdformat 9.8 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
I've removed |
Thanks. I opened two PRs to hopefully avoid this problem in the future:
|
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
May 27, 2022
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebo-release/gazebo11-release
that referenced
this pull request
May 27, 2022
Follow-up to gazebosim/gazebo-classic#3213 and gazebosim/gazebo-classic#3223 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebo-release/gazebo11-release
that referenced
this pull request
May 27, 2022
Follow-up to gazebosim/gazebo-classic#3213 and gazebosim/gazebo-classic#3223 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jun 16, 2022
Reverts a portion of #3223 that broke shininess functionality. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jun 16, 2022
Reverts a portion of #3223 that broke shininess functionality. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
5 tasks
scpeters
added a commit
that referenced
this pull request
Jun 29, 2022
* Add Visual::Shininess accessor and corresponding visual_shininess integration test that confirms shininess values are properly added to Visuals in the shapes_shininess example world. * Fix the test by reverting part of #3223, moving the shininess service call back to Visual::Load. A different fix for the PR2 tests is made by checking for existence of shininess service before calling. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
8 tasks
traversaro
added a commit
that referenced
this pull request
Jan 12, 2023
In #3223 (comment) we added some workarounds for the conda-forge CI, namely pin the version of some dependencies and removed dartsim. Now that the long term fixes to that problems (linked in #3223 (comment)) has been fixed, we can remove the workarounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The material shininess features added in #3213 introduced a few test regressions that we difficult to notice due to the large number of existing test failures in our CI. Having been able to observe several sets of builds since then, I've noticed the following test failures that I believe we introduced:
The
PhysicsEngines/NestedModelTest.SpawnNestedModel/*tests (and possiblyModelListWidget_TEST.NestedLinkProperties) should be fixed by b29d38c (diff without whitespace). The remaining tests should be fixed by 6c4c188.