Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work order ID and task ID #71

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Work order ID and task ID #71

wants to merge 10 commits into from

Conversation

aaronchongth
Copy link
Collaborator

@aaronchongth aaronchongth commented Feb 3, 2025

Addresses #63 (comment)

This will help with creating unique workcell task IDs, to be used for signals in parallel work orders, #63

  • Added work order ID, renamed ID to task ID where applicable, migrate changes and populate fields
  • removed step ID per discussion, update tests
  • removed number from work orders as well
  • generate task ID as {work_order_id}/{process_id}/{step_index}, where step_index is the index of this step in the whole list, starting from 0
  • added test for parallel duplicated orders just with different work order IDs

Verify

# Run demo
ros2 launch nexus_demos launch.py headless:=0

# Run work order
cd ~/ws_nexus/src/nexus/nexus_demos/
ros2 action send_goal /system_orchestrator/execute_order nexus_orchestrator_msgs/action/ExecuteWorkOrder "{order: {id: '1', work_order: '$(cat config/pick_and_place.json)'}}"

# Check topics, verify that work order ID is populated by the goal action ID , task ID is populated with {work_order_id}/{process_id}/{step_index}
ros2 topic echo /workcell_1/workcell_state
ros2 topic echo /workcell_2/workcell_state

@aaronchongth aaronchongth requested review from Yadunund and removed request for Yadunund February 3, 2025 17:29
@aaronchongth aaronchongth marked this pull request as draft February 3, 2025 17:45
@aaronchongth aaronchongth marked this pull request as ready for review February 4, 2025 10:37
@aaronchongth aaronchongth requested a review from Yadunund February 4, 2025 10:37
@aaronchongth aaronchongth marked this pull request as draft February 10, 2025 06:44
@aaronchongth aaronchongth marked this pull request as ready for review February 10, 2025 09:51
@aaronchongth aaronchongth removed the request for review from Yadunund February 12, 2025 02:04
@aaronchongth aaronchongth marked this pull request as draft February 12, 2025 02:04
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…use that for work_order_id

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
… parallel duplicate wo test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ot killing zenoh

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review February 12, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant