-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating Your First ROS2 Package #954
Comments
I'll take this one. |
"Package" terminology is inconsistent. There is a fine definition at Glossary. But then, at https://docs.ros.org/en/iron/Tutorials/Beginner-Client-Libraries/Creating-Your-First-ROS2-Package.html#what-is-a-ros-2-package:
The fix:
|
"Build system", "build tool", "build type" terminology is inconsistent.
The ament Github doesn't have any doc, so I asked google and found The build system ament_cmake and the meta build tool ament_tools:
|
Error in the doc at What makes up a ROS 2 package:
But the preceding paragraph stated:
So, "resource/my_package" isn't mentioned in the requirements, and the simplest package doesn't contain "/<package_name>" as per the requirements. |
Thanks for the valuable feedback. I've added your points to the ongoing discussion on documentation improvements #1047 Apart from the documentation errors, any issues with creating the package itself? |
@Yadunund , I decided to run through all of the preceding tutorials (even though Tyler already closed the corresponding issues) because each tutorial expects that you've been through the previous tutorials. Almost done. |
I will check the procedure too (including aarch64 platform), /assign @fujitatomoya |
osrf/ros2_test_cases#954 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
osrf/ros2_test_cases#954 Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
can you guys take a look at ros2/ros2cli#827 and ros2/ros2_documentation#3535. everything else works w/o any problems, including aarch64 platform. |
osrf/ros2_test_cases#954 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
osrf/ros2_test_cases#954 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit ad7fec5)
osrf/ros2_test_cases#954 Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit ad7fec5) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
See ros2/ros2_documentation#3540 for a small update to make it more consistent with the Glossary. |
See ros2/ros2_documentation#3541 for a fix. |
This is actually a larger problem, in that we actually don't have completely standardized terms for all of this. Fixing this up means first agreeing on standard terms, and then updating all of the documentation with it. That is a worthwhile effort, but beyond the scope of what we are going to do for the Iron release. @cdhabecker What I'll suggest here is opening an issue over at https://github.com/ros2/ros2_documentation , mentioning that this is a problem that we should follow up with later on. With that, I'm going to close this issue out. Thank you for the testing. |
* ros2pkg generates license warning messages. osrf/ros2_test_cases#954 * use `--license` option for the tutorial with ros2pkg command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
* ros2pkg generates license warning messages. osrf/ros2_test_cases#954 * use `--license` option for the tutorial with ros2pkg command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit f29796f)
* ros2pkg generates license warning messages. osrf/ros2_test_cases#954 * use `--license` option for the tutorial with ros2pkg command. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit f29796f) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Check the documentation for the 'Creating Your First ROS2 Package' page
Setup
Links
Checks
You can find the code used to generate this test case here
The text was updated successfully, but these errors were encountered: