Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ros2pkg generates license warning messages. #3535

Merged
merged 3 commits into from
May 8, 2023
Merged

ros2pkg generates license warning messages. #3535

merged 3 commits into from
May 8, 2023

Conversation

fujitatomoya
Copy link
Collaborator

@fujitatomoya
ros2pkc generates license warning messages.
3fde471 
  osrf/ros2_test_cases#954

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya mentioned this pull request May 6, 2023
Closed
3 tasks
@fujitatomoya
Copy link
Collaborator Author

This needs to be aligned with ros2/ros2cli#827

CC: @Yadunund @clalancette

clalancette
clalancette requested changes May 7, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding in this warning text, I would rather change the command so the warning doesn't appear. That is, change the ros2 pkg create command to add in the --license Apache-2.0 flag.

@clalancette clalancette changed the title ros2pkc generates license warning messages. ros2pkg generates license warning messages. May 7, 2023
@fujitatomoya
Copy link
Collaborator Author

@clalancette thanks, that makes sense to me. i will update it as you suggested.

@fujitatomoya
use --license option for the tutorial with ros2pkg command.
396429b 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette requesting another review. thanks in advance.

clalancette
clalancette requested changes May 8, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more small fix, then this is good to go.

source/Tutorials/Beginner-Client-Libraries/Creating-Your-First-ROS2-Package.rst Outdated Show resolved Hide resolved
@fujitatomoya
typo fix.
33d6fac 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@clalancette clalancette added the backport-iron backport at reviewers discretion; from rolling to iron label May 8, 2023
@clalancette clalancette merged commit f29796f into rolling May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fujitatomoya/ros2pkg-license-warning branch May 8, 2023 23:57
mergify bot pushed a commit that referenced this pull request May 8, 2023
@fujitatomoya @mergify
ros2pkg generates license warning messages. (#3535)
1fea925 
* ros2pkg generates license warning messages.

  osrf/ros2_test_cases#954

* use `--license` option for the tutorial with ros2pkg command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f29796f)
@mergify mergify bot mentioned this pull request May 8, 2023
Merged
clalancette pushed a commit that referenced this pull request May 9, 2023
@mergify @fujitatomoya
ros2pkg generates license warning messages. (#3535) (#3560)
46fdf7a 
* ros2pkg generates license warning messages.

  osrf/ros2_test_cases#954

* use `--license` option for the tutorial with ros2pkg command.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit f29796f)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-iron backport at reviewers discretion; from rolling to iron
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @clalancette