Correct use without deprecated GraphQL::execute()?

[vhenzl]

GraphQL::execute() has been deprecated many versions ago.

There are two examples of how to use dataloaders with webonyx/graphql-php (I'm aware of):

A test in this project:

dataloader-php/tests/Functional/Webonyx/GraphQL/TestCase.php

Line 84 in 9a3be90

$response = GraphQL::execute($schema, $query);

And https://github.com/mcg-web/sandbox-dataloader-graphql-php. But both use this deprecated API.

What's the correct use without deprecated GraphQL::execute() (particularly in combination with the "native" SyncPromise)?

GraphQL::executeQuery() can't be use as it internally always uses GraphQL\Executor\Promise\Adapter\SyncPromiseAdapter\SyncPromiseAdapter instance, not Overblog\DataLoader\Promise\Adapter\Webonyx\GraphQL\SyncPromiseAdapter instance set with GraphQL::setPromiseAdapter() and it's execution results in "GraphQL\Error\InvariantViolation: Could not resolve promise" error.

Assuming from this comment, the whole use of GraphQL::setPromiseAdapter() should be considered deprecated and for all cases that don't use GraphQL\Executor\Promise\Adapter\SyncPromiseAdapter\SyncPromiseAdapter, GraphQL::promiseToExecute() should be used.

Given these adapters:

use Overblog\DataLoader\Promise\Adapter\Webonyx\GraphQL\SyncPromiseAdapter;
use Overblog\PromiseAdapter\Adapter\WebonyxGraphQLSyncPromiseAdapter;

$graphQLPromiseAdapter = new SyncPromiseAdapter();
$dataLoaderPromiseAdapter = new WebonyxGraphQLSyncPromiseAdapter($graphQLPromiseAdapter);

I see two possible solutions. Either:

$promise = GraphQL::promiseToExecute($graphQLPromiseAdapter, $schema, $query /* ... */);
$result = $graphQLPromiseAdapter->wait($promise);

which kinda replicates what GraphQL::execute() does, or:

$promise = GraphQL::promiseToExecute($graphQLPromiseAdapter, $schema, $query /* ... */);
$result = DataLoader::await($promise)->toArray();    

Is that correct? Both works and seems to work equally. Is there any real difference between them? Any pros and cons using one over the other?

[vhenzl]

#36 likely related.

[vhenzl]

The second option with DataLoader::await() doesn't seem to be correct. It can fail with "Found no active DataLoader instance" error if no field returning a promise queried - for instance during introspection.

[simPod]

I have dropped deprecated api in tests in #51