Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP 8 #40

Closed
vhenzl opened this issue Dec 5, 2020 · 1 comment · Fixed by #41
Closed

Support for PHP 8 #40

vhenzl opened this issue Dec 5, 2020 · 1 comment · Fixed by #41

Comments

@vhenzl
Copy link
Contributor

vhenzl commented Dec 5, 2020

The library should be updated to support PHP 8.

Doing so, older PHP versions could be removed, tests for PHP 7.3 should be fixed (failing currently) and added for PHP 7.4. Also, dev dependencies should be bumped - webonyx/graphql-php v0.11 vs current v14.

I'm happy to prepare a PR…
@mcg-web
Copy link
Member

mcg-web commented Dec 5, 2020

@vhenzl a PR will be welcome for this change 👍 .

@vhenzl vhenzl mentioned this issue Dec 6, 2020
Merged
mcg-web pushed a commit that referenced this issue Dec 7, 2020
@vhenzl
Add support for PHP 8 (#41)
a2a11bb 
* Drop hhvm from build matrix

* Bump minimal PHP version to 7.1

* Remove PHP 7.3 from allowed failures

* Add PHP 7.4 to build matrix

* Check platform requirements

* Replace `\PHPUnit_Framework_TestCase` with `\PHPUnit\Framework\TestCase`

* Bump PHPUnit to version 7.5

* Bump `webonyx/graphql-php` to version 0.13

* Prefer package sources on `composer update`

`tests/StarWarsData.php` is no longer part of `webonyx/graphql-php` package

* Fix deprecation for `GraphQL\Schema`

* Suppress deprecation errors in tests

* Bump `webonyx/graphql-php` to version 14

* Bump PHPUnit to version 8.5

* Allow PHPUnit 7 for compatibility with PHP 7.1

* Allow PHP 8

* Use current version of `php-cs-fixer`

* Switch Travis CI from `trusty` to `bionic`

* Add PHP 8.0 to the build matrix

* Don't run `php-cs-fixer` for PHP 8.0

Resolves #40.

Minimal PHP version increased to 7.1. (So that supported versions are same as in webonyx/graphql-php. Going up to 7.2 would make things easier regarding PHPUnit.)
Installation on PHP 8 allowed.
composer check-platform-reqs added to build steps
PHPUnit bumped to ^7.5|^8.5 to support PHP 7.1-8.0
webonyx/graphql-php updated to the current version 14
--prefer-source used for composer update as tests/StarWarsData.php is no longer part of webonyx/graphql-php package. Alternative options would be to create a local copy of the file in this repository or download it from webonyx/graphql-php repo with wget in before_install.
The current version of php-cs-fixer (2.16) used, however, it doesn't allow installation on PHP 8 yet (see PHP-CS-Fixer/PHP-CS-Fixer#4702).
PHPUnit option convertDeprecationsToExceptions disabled to deal with deprecated GraphQL::execute() (related to #39).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for PHP 8
2 participants
@vhenzl @mcg-web