Add support for PHP 8 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tests/StarWarsData.php` is no longer part of `webonyx/graphql-php` package
Try with |
|
PHP 8.0 is available today so this should be good to go now. |
|
Thank you @vhenzl ! |
This was referenced Dec 7, 2020
|
@mcg-web Any chance of releasing this? Please 🙏 |
|
done in https://github.com/overblog/dataloader-php/releases/tag/v0.6.0 . Thanks again @vhenzl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40.
webonyx/graphql-php. Going up to 7.2 would make things easier regarding PHPUnit.)composer check-platform-reqsadded to build steps^7.5|^8.5to support PHP 7.1-8.0webonyx/graphql-phpupdated to the current version 14--prefer-sourceused forcomposer updateastests/StarWarsData.phpis no longer part ofwebonyx/graphql-phppackage. Alternative options would be to create a local copy of the file in this repository or download it fromwebonyx/graphql-phprepo withwgetinbefore_install.php-cs-fixer(2.16) used, however, it doesn't allow installation on PHP 8 yet (see PHP 8.0 support PHP-CS-Fixer/PHP-CS-Fixer#4702).convertDeprecationsToExceptionsdisabled to deal with deprecatedGraphQL::execute()(related to Correct use without deprecatedGraphQL::execute()? #39).All looks good apart from maybe the most important thing - Travis CI doesn't support PHP 8 yet. PHP 8.0 is available under
nightlyversion but contains an ancient version (PHP 8.0.0-dev (cli) (built: Jan 7 2020 22:28:03) ( ZTS )) so it can't be trusted.How do you want me to proceed? Should we wait for Travis CI? Or maybe migrate to Github Actions?