[Tests-only] Use valid Depth values in tests #37437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
changed the title
|
hah... |
phil-davis
reviewed
May 22, 2020
|
fixed the tags depth arg |
PVince81
force-pushed
the
tests-use-valid-depth
branch
from
8c416aa to
01197a0
Compare
phil-davis
approved these changes
May 22, 2020
Added validation to prevent using invalid depths and causing failure against OCIS servers. Fixes occurrences of invalid depth values and used infinity instead.
PVince81
force-pushed
the
tests-use-valid-depth
branch
from
01197a0 to
ff79bb0
Compare
|
for some reason depth 0 did not work for the tags test, so I've set it to 1 now (it passes locally). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation to prevent using invalid depths and causing failure
against OCIS servers.
Fixes occurrences of invalid depth values and used infinity instead.
Context: owncloud/ocis-reva#221 (comment)