This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
seems I missed ocis-pkg, if relevant here as well checklist here: owncloud/web#3186 |
|
restarted build, to confirm this still works |
failing. likely related to #221 (comment) |
|
This was referenced May 22, 2020
the Phoenix tests should be fixed now, restarting build |
right, needed to rebase |
according to https://cloud.drone.io/owncloud/ocis-reva/391 it's all green. |
so we managed to solve #221 after all
|
updated with latest changes |
oh no, Phoenix tests again ?!
|
ok, it was some timeout issue. @micbar please approve |
micbar
approved these changes
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for CI in owncloud/ocis#285 as it's sitting on the same commit efaa4fa