Update reva to v0.1.1-0.20200520150229 #221

PVince81 · 2020-05-22T07:27:10Z

No description provided.

PVince81 · 2020-05-22T08:16:09Z

20 failures

C0rby · 2020-05-22T08:18:12Z

This should fix some tests. owncloud/core#37396

PVince81 · 2020-05-22T08:21:55Z

let me temporarily point this PR at the core one to confirm

PVince81 · 2020-05-22T08:23:28Z

merge [Tests-Only] update reva api tests related to sharing core#37396
revert drone branch pointer to master

PVince81 · 2020-05-22T08:49:51Z

hmmm, strange. API tests still fail with sharing: https://cloud.drone.io/owncloud/ocis-reva/371/2/6

@C0rby

C0rby · 2020-05-22T08:51:12Z

Ok let me check locally.

C0rby · 2020-05-22T09:03:06Z

That's strange. Locally I get these errors.

Failed scenarios:

    tests/acceptance/features/apiMain/checksums.feature:255
    tests/acceptance/features/apiMain/checksums.feature:256
    tests/acceptance/features/apiWebdavMove2/moveFile.feature:21
    tests/acceptance/features/apiWebdavMove2/moveFile.feature:22
    tests/acceptance/features/apiWebdavOperations/deleteFolderContents.feature:31
    tests/acceptance/features/apiWebdavOperations/deleteFolderContents.feature:32
    tests/acceptance/features/apiWebdavOperations/downloadFile.feature:40
    tests/acceptance/features/apiWebdavOperations/downloadFile.feature:41

PVince81 · 2020-05-22T09:04:07Z

let's investigate in detail next week as I'd like to focus on releases today

PVince81 · 2020-05-22T09:04:48Z

I'll release without this update in #215.

Still, will rebase that branch to see if CI is still running propertly in case some new test issues have sneaked in somehow

PVince81 · 2020-05-22T09:13:04Z

something is fishy... I tried one of the tests "tests/acceptance/features/apiWebdavOperations/downloadFile.feature:40" and it also fails on #215 where it passed before.

C0rby · 2020-05-22T09:14:51Z

I think there have been some changes to the tests. I see that the test user is now "Alice" and not "user0".

phil-davis · 2020-05-22T09:18:12Z

I think there have been some changes to the tests. I see that the test user is now "Alice" and not "user0".

In core the acceptance test features were change to use "realistic" user names. In theory there should be no problem! I suspect that the most likely problem might be if a system-under-test behaves differently to ownCloud10 when the username is mixed-case.

PVince81 · 2020-05-22T09:20:14Z

I tried reverting to the commit before the name changes, but the test still fails

PVince81 · 2020-05-22T09:23:19Z

In my local log I saw errors about invalid Depth header values that were used in the tests.

Since cs3org/reva#758 those values are forbidden.

I'll have a look and fix all the tests that use an invalid depth value to use infinity instead

PVince81 · 2020-05-22T09:28:14Z

Confirmed: when I sit on the commit before the Depth validation, the test passes.

PVince81 · 2020-05-22T09:34:11Z

PR here to fix invalid depth values and pre-validate: owncloud/core#37437

PVince81 · 2020-05-22T09:34:56Z

and adjusted the drone config to test against that PR

PVince81 · 2020-05-22T09:57:39Z

failures now:

/srv/app/testrunner/tests/acceptance/features/apiAuthOcs/ocsGETAuth.feature:99
/srv/app/testrunner/tests/acceptance/features/apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:64
/srv/app/testrunner/tests/acceptance/features/apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:101
/srv/app/testrunner/tests/acceptance/features/apiShareCreateSpecial2/createShareWithInvalidPermissions.feature:103
/srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:92
/srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:95
/srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:98
/srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:101
/srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:131
/srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:240

at least no more checksum, etc.

next up: to test with owncloud/core#37396 as well

PVince81 · 2020-05-22T09:59:22Z

pushed again drone change using the core branch "tests-valid-depth-and-shares-update" which contains both the Depth fixes and the sharing ones

PVince81 · 2020-05-22T10:25:53Z

ok, so once we merge both owncloud/core#37396 and owncloud/core#37437 there are still remaining failures:

    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:56
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:57
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:59
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:60
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:62
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:63
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:65
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:66

there likely for @C0rby to check ^

dpakach · 2020-05-22T12:28:03Z

@PVince81 phoenix ui tests have passed in #223, please review and rebase on that

PVince81 · 2020-05-22T12:31:39Z

I've merged #223 but will rebase later once at least owncloud/core#37396 is merged.

for the remaining failing API tests from #221 (comment) we can either debug them or skip them

C0rby · 2020-05-22T12:57:23Z

ok, so once we merge both owncloud/core#37396 and owncloud/core#37437 there are still remaining failures:

    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:56
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:57
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:59
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:60
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:62
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:63
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:65
    /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:66

there likely for @C0rby to check ^

I can't reproduce that locally. They are running green on my machine....

PVince81 · 2020-05-22T13:29:04Z

ok owncloud/core#37437 is merged.

@C0rby can you rebase owncloud/core#37396 ?

PVince81 · 2020-05-22T13:30:26Z

I've rebased this PR, and pointed it again at owncloud/core#37396

C0rby · 2020-05-22T13:38:26Z

ok owncloud/core#37437 is merged.

@C0rby can you rebase owncloud/core#37396 ?

Done

PVince81 · 2020-05-22T18:36:38Z

I've restarted the build now, we should get results. I suspect we will only see those createShare issues. We'll see.

PVince81 · 2020-05-25T06:46:44Z

No more Phoenix failures.
Remaining failures as before on the mixed branch:

     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:56
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:57
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:59
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:60
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:62
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:63
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:65
     /srv/app/testrunner/tests/acceptance/features/apiShareManagementBasic/createShare.feature:66

PVince81 · 2020-05-25T06:57:11Z

those tests pass locally for me as well... hmmm

PVince81 · 2020-05-25T07:01:05Z

ok got it, it's the "missing mimetype value" again.

see #67 (comment)

I think we should fix the Drone env to actually have a proper /etc/mime.types folder.
Might need to apt-get some extra package on those images ?

@individual-it @dpakach

PVince81 · 2020-05-25T07:03:23Z

I believe the dockers are based on Alpine, so it should be a matter of installing "mailcap", see https://pkgs.alpinelinux.org/contents?file=mime.types&path=&name=mailcap&branch=edge&repo=main&arch=armhf

PVince81 · 2020-05-25T07:06:41Z

naive attempt in this separate PR to add mime.types file in Drone: #224

C0rby

Nice. 👍

PVince81 · 2020-05-25T08:03:52Z

@C0rby can you undraft owncloud/core#37396 and I hope @individual-it can review/approve it, then we should merge both at the same time

PVince81 · 2020-05-25T08:05:10Z

right, not merging at the same time. here is the correct plan:

undraft [Tests-Only] update reva api tests related to sharing core#37396 and get approval
merge [Tests-Only] update reva api tests related to sharing core#37396
adjust this PR here (Update reva to v0.1.1-0.20200520150229 #221) to point again at master and wait for CI
merge this PR

PVince81 · 2020-05-25T08:47:03Z

rebased and made the branch point back to core master.

PVince81 requested review from C0rby and refs May 22, 2020 07:27

PVince81 self-assigned this May 22, 2020

PVince81 mentioned this pull request May 22, 2020

Prepare for 0.3.0 release #215

Merged

PVince81 mentioned this pull request May 22, 2020

[Tests-only] Use valid Depth values in tests owncloud/core#37437

Merged

This was referenced May 22, 2020

[Tests-only] Reenable upload related tests owncloud/web#3457

Merged

Disable failing upload tests owncloud/web#3492

Closed

Update reva to v0.1.1-0.20200520150229

fc50ee3

PVince81 force-pushed the update-ocis-reva-for-sharing-fixes branch from 515e950 to f5def32 Compare May 22, 2020 13:29

C0rby approved these changes May 25, 2020

View reviewed changes

PVince81 marked this pull request as draft May 25, 2020 08:15

Add mime types file in Drone env

b035292

PVince81 force-pushed the update-ocis-reva-for-sharing-fixes branch from 208aa4a to b035292 Compare May 25, 2020 08:46

PVince81 marked this pull request as ready for review May 25, 2020 08:53

PVince81 merged commit 2be681b into master May 25, 2020

delete-merged-branch bot deleted the update-ocis-reva-for-sharing-fixes branch May 25, 2020 09:23

PVince81 mentioned this pull request May 25, 2020

[Tests-only] Fix invalid depth header for recursion owncloud/web#3480

Merged

1 task

Update reva to v0.1.1-0.20200520150229 #221

Update reva to v0.1.1-0.20200520150229 #221

Conversation

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

C0rby commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

C0rby commented May 22, 2020

C0rby commented May 22, 2020 • edited Loading

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

C0rby commented May 22, 2020

phil-davis commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020 • edited Loading

PVince81 commented May 22, 2020

dpakach commented May 22, 2020

PVince81 commented May 22, 2020

C0rby commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 22, 2020

C0rby commented May 22, 2020

PVince81 commented May 22, 2020

PVince81 commented May 25, 2020

PVince81 commented May 25, 2020

PVince81 commented May 25, 2020

PVince81 commented May 25, 2020

PVince81 commented May 25, 2020

C0rby left a comment

Choose a reason for hiding this comment

PVince81 commented May 25, 2020

PVince81 commented May 25, 2020 • edited Loading

PVince81 commented May 25, 2020

C0rby commented May 22, 2020 •

edited

Loading

PVince81 commented May 22, 2020 •

edited

Loading

PVince81 commented May 25, 2020 •

edited

Loading