Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/xcstrings-build-normalization] Normalize xcstrings on every build #131

Closed
wants to merge 6 commits into from

Conversation

felix-schwarz
Copy link
Collaborator

@felix-schwarz felix-schwarz commented Nov 24, 2024

Description

Adds a xcstrings normalization build step that normalizes the xcstrings files on every build. Since Xcode's format slightly diverges from the normalized version created by jq, this normalization step seeks to avoid large diffs for what is effectively few or no changes.

@felix-schwarz felix-schwarz self-assigned this Nov 24, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 24, 2024

CLA assistant check
All committers have signed the CLA.

@felix-schwarz felix-schwarz changed the title [feature/xcstrings-build-normalization] xcstrings build normalization [feature/xcstrings-build-normalization] Normalize xcstrings on every build Nov 24, 2024
@DeepDiver1975
Copy link
Member

we might want to add this as a ci check to make sure only properly formatted xcstrings files are committed.

@felix-schwarz
Copy link
Collaborator Author

Superseded by #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants