[fix/xcstrings-format] xcstrings normalization to Xcode style #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs files - pull-transifex.yml: add ocstringstool xcstrings normalization step - cleanup: remove unused .github/workflows.inactive/normalizestrings.yml
.github/workflows/pull-transifex.yml
Outdated
| @@ -31,6 +31,33 @@ jobs: | |||
| beautifyJSON "ownCloudSDK/Resources/Localizable.xcstrings" | |||
| beautifyJSON "ownCloudUI/Resources/Localizable.xcstrings" | |||
|
|
|||
| - name: Install dependencies | |||
There was a problem hiding this comment.
Isn't there any pre-built docker image with swift which can be used? Installing swift to compile a build steps feels wrong.
Default GitHub images come with so many pre-installed interpreters - there must be an easier solution ....
There was a problem hiding this comment.
You're right. Upon looking into it, I quickly discovered a GH action for setting up Swift and updated the yml accordingly. Please have another look now.
…wift-actions/setup-swift@v2
…source from fix/xcstrings-format
…f ocstringstool's main.swift and to show its contents
felix-schwarz
force-pushed
the
fix/xcstrings-format
branch
from
1d3e78a to
e257837
Compare
hosy
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goal: improve development experience with xcstrings files