-
-
Notifications
You must be signed in to change notification settings - Fork 722
fix(transformer/styled-components): fix block comment containing expression in CSS minification #13370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
08-28-fix_transformer_styled-components_fix_block_comment_containing_expression_in_css_minification
Aug 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
CodSpeed Instrumentation Performance ReportMerging #13370 will not alter performanceComparing Summary
Footnotes |
This was referenced Aug 28, 2025
Merged
refactor(transformer/styled-components): clarify whitespace removal logic in CSS minification
#13375
Merged
99b0af8 to
4caa808
Compare
f5196e5 to
0b252d8
Compare
Contributor
Merge activity
|
…ession in CSS minification (#13370) Fix handling block comments which contain an expression. Previously if that block comment ended exactly before another expression, the comment wouldn't be considered closed, and all remaining parts of the template literal would be removed. Input: ```js styled.div`${x}/* ${y} */${z}` ``` Previous output post-minification: ```js styled.div`${x}` ``` After this PR: ```js styled.div`${x}${z}` ``` This bug was introduced way back in #12224 (my fault!), but had gone unnoticed.
0b252d8 to
35d83ca
Compare
4caa808 to
a7a06b7
Compare
Base automatically changed from
08-28-fix_transformer_styled-components_remove_repeat_whitespace_in_css_minification
to
main
August 29, 2025 03:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fix handling block comments which contain an expression. Previously if that block comment ended exactly before another expression, the comment wouldn't be considered closed, and all remaining parts of the template literal would be removed.
Input:
Previous output post-minification:
After this PR:
This bug was introduced way back in #12224 (my fault!), but had gone unnoticed.