-
-
Notifications
You must be signed in to change notification settings - Fork 723
fix(transformer/styled-components): remove space before line comment in CSS minification #13371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
graphite-app
merged 1 commit into
main
from
08-28-fix_transformer_styled-components_remove_space_before_line_comment_in_css_minification
Aug 29, 2025
Merged
fix(transformer/styled-components): remove space before line comment in CSS minification #13371
graphite-app
merged 1 commit into
main
from
08-28-fix_transformer_styled-components_remove_space_before_line_comment_in_css_minification
Aug 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
097b9ee to
167d41a
Compare
CodSpeed Instrumentation Performance ReportMerging #13371 will not alter performanceComparing Summary
Footnotes |
This was referenced Aug 29, 2025
refactor(transformer/styled-components): clarify whitespace removal logic in CSS minification
#13375
Merged
167d41a to
90c09c4
Compare
99b0af8 to
4caa808
Compare
Contributor
Merge activity
|
…in CSS minification (#13371) Previously we'd include an unnecessary space when removing a line comment in cases like: Input: ```js styled.div` .a // comment { color: red; } ` ``` Previous output post-minification: ```js styled.div`.a {color:red;}` ``` After this PR: ```js styled.div`.a{color:red;}` ``` We still include excess spaces when removing block comments (e.g. ``styled.div`.a /* */ {}` `` -> ``styled.div`.a {}` ``), but that's more complicated to fix, so leaving it for now.
4caa808 to
a7a06b7
Compare
90c09c4 to
df38b2c
Compare
Base automatically changed from
08-28-fix_transformer_styled-components_fix_block_comment_containing_expression_in_css_minification
to
main
August 29, 2025 03:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Previously we'd include an unnecessary space when removing a line comment in cases like:
Input:
Previous output post-minification:
After this PR:
We still include excess spaces when removing block comments (e.g.
styled.div`.a /* */ {}`->styled.div`.a {}`), but that's more complicated to fix, so leaving it for now.