Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Aug 29, 2025

Trim whitespace from end of last quasi.

Have not added a test, because this reduces the mismatch in existing minify-single-line-comments-with-interpolations test.

Copy link
Member Author

overlookmotel commented Aug 29, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 29, 2025

CodSpeed Instrumentation Performance Report

Merging #13376 will not alter performance

Comparing 08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification (1fca9b8) with main (8f98841)1

Summary

✅ 38 untouched benchmarks

Footnotes

  1. No successful run was found on 08-29-refactor_transformer_styled-components_clarify_whitespace_removal_logic_in_css_minification (be6677e) during the generation of this report, so main (8f98841) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review August 29, 2025 00:56
@overlookmotel overlookmotel requested a review from Dunqing as a code owner August 29, 2025 00:56
@overlookmotel overlookmotel force-pushed the 08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification branch from 7bfce7c to 857ab3b Compare August 29, 2025 01:18
@overlookmotel overlookmotel force-pushed the 08-29-refactor_transformer_styled-components_clarify_whitespace_removal_logic_in_css_minification branch from a93004b to 138872a Compare August 29, 2025 01:18
@overlookmotel overlookmotel force-pushed the 08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification branch from 857ab3b to 68001f8 Compare August 29, 2025 01:23
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 29, 2025

Merge activity

… minification (#13376)

Trim whitespace from end of last quasi.

Have not added a test, because this reduces the mismatch in existing `minify-single-line-comments-with-interpolations` test.
@graphite-app graphite-app bot force-pushed the 08-29-refactor_transformer_styled-components_clarify_whitespace_removal_logic_in_css_minification branch from 138872a to be6677e Compare August 29, 2025 03:17
@graphite-app graphite-app bot force-pushed the 08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification branch from 68001f8 to 1fca9b8 Compare August 29, 2025 03:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 29, 2025
Base automatically changed from 08-29-refactor_transformer_styled-components_clarify_whitespace_removal_logic_in_css_minification to main August 29, 2025 03:23
@graphite-app graphite-app bot merged commit 1fca9b8 into main Aug 29, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 08-29-fix_transformer_styled-components_remove_trailing_whitespace_in_css_minification branch August 29, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants