fix(tasks): use same version of antd.js for all tasks
#13465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a fixture version inconsistency issue where different tasks were using different versions of antd.js, causing unpredictable behavior when tasks download to the same target directory.
- Standardizes
antd.jsfixture version to v4.16.1 across all tasks - Updates file size comment to reflect the correct size for v4.16.1 (6.7M)
- Aligns with existing version used in
minifierfunction perprivatenumber/minification-benchmarks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13465 will not alter performanceComparing Summary
|
camchenry
approved these changes
Aug 31, 2025
Member
Author
|
@Boshen I've asked for your review because I'm not 100% sure that v4.16.1 was the right version to choose. |
Boshen
deleted the
08-31-fix_tasks_use_same_version_of_antd.js_for_all_tasks
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
overlookmotel
added a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
#13465 aligned the version of `antd.js` used in different Rust tasks to v4.16.1. But it missed a couple of places in `napi/parser` tests/benchmarks. Align these to same version too. Misalignment was problematic as the tasks using these fixtures all download the file to same location (`target` dir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minifier()andcomplicated()were using different versions ofantd.jsas fixtures.This was problematic as the tasks using these fixtures all download the file to same location (
targetdir) and don't re-download if the file is already present. This lead to unpredictable results depending on which task you ran first, and so which version was downloaded.Use v4.16.1 for both. I chose v4.16.1 rather than v5.12.5, because there's a comment above
minifierfunction saying the versions there (v4.16.1) are kept in sync withprivatenumber/minification-benchmarks.