-
-
Notifications
You must be signed in to change notification settings - Fork 722
refactor(syntax): remove unnecessary #[estree(field_order)] attr
#14142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(syntax): remove unnecessary #[estree(field_order)] attr
#14142
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes an unnecessary #[estree(field_order)] attribute from the NameSpan struct, as the span field is now automatically positioned as the last field without explicit ordering.
- Removes the explicit field ordering specification from the
#[estree]attribute
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
#[estree(field_order)] attr#[estree(field_order)] attr
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #14142 will not alter performanceComparing Summary
|
…14142) `span` is now automatically moved to be last field, so no need to specify field order explicitly here.
9adceab to
0a9473d
Compare

spanis now automatically moved to be last field, so no need to specify field order explicitly here.