Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 26, 2025

span is now automatically moved to be last field, so no need to specify field order explicitly here.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Sep 26, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review September 26, 2025 08:41
Copilot AI review requested due to automatic review settings September 26, 2025 08:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an unnecessary #[estree(field_order)] attribute from the NameSpan struct, as the span field is now automatically positioned as the last field without explicit ordering.

  • Removes the explicit field ordering specification from the #[estree] attribute

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@overlookmotel overlookmotel changed the title refactor(syntax): remove unneccesary #[estree(field_order)] attr refactor(syntax): remove unnecessary #[estree(field_order)] attr Sep 26, 2025
@overlookmotel overlookmotel self-assigned this Sep 26, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
Copy link
Member Author

overlookmotel commented Sep 26, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 26, 2025

CodSpeed Instrumentation Performance Report

Merging #14142 will not alter performance

Comparing 09-26-refactor_syntax_remove_unneccesary_estree_field_order_attr (0a9473d) with main (5e05d1b)

Summary

✅ 37 untouched

…14142)

`span` is now automatically moved to be last field, so no need to specify field order explicitly here.
@graphite-app graphite-app bot force-pushed the 09-26-refactor_syntax_remove_unneccesary_estree_field_order_attr branch from 9adceab to 0a9473d Compare September 26, 2025 08:46
@graphite-app graphite-app bot merged commit 0a9473d into main Sep 26, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 09-26-refactor_syntax_remove_unneccesary_estree_field_order_attr branch September 26, 2025 08:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants