Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Sep 26, 2025

span is now automatically moved to be last field, so no need to specify field orders explicitly here.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 26, 2025
Copy link
Member Author

overlookmotel commented Sep 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 26, 2025

CodSpeed Instrumentation Performance Report

Merging #14143 will not alter performance

Comparing 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs (6fffdf9) with main (fc7026d)

Summary

✅ 37 untouched

@graphite-app graphite-app bot changed the base branch from 09-26-refactor_syntax_remove_unneccesary_estree_field_order_attr to graphite-base/14143 September 26, 2025 08:45
@graphite-app graphite-app bot force-pushed the graphite-base/14143 branch from 9adceab to 0a9473d Compare September 26, 2025 08:52
@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from e185797 to a394e91 Compare September 26, 2025 08:52
@graphite-app graphite-app bot changed the base branch from graphite-base/14143 to main September 26, 2025 08:53
@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from a394e91 to 38caec5 Compare September 26, 2025 08:53
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
Copy link
Member Author

overlookmotel commented Sep 26, 2025

Merge activity

  • Sep 26, 9:00 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:06 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 26, 9:12 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test Linux').
  • Sep 26, 9:35 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Sep 26, 9:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 26, 9:36 AM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Sep 26, 9:40 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 26, 9:40 AM UTC: Merged by the Graphite merge queue.

Copilot AI review requested due to automatic review settings September 26, 2025 09:01
@overlookmotel overlookmotel force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from 38caec5 to dc6b90b Compare September 26, 2025 09:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes unnecessary #[estree(field_order)] attributes from AST struct definitions since the span field is now automatically moved to be the last field.

  • Removes explicit field ordering declarations from estree attributes
  • Simplifies estree attribute configurations by removing redundant field_order specifications
  • Updates field ordering in add_fields to match automatic span positioning

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_ast/src/ast/ts.rs Removes field_order attribute and reorders add_fields parameters
crates/oxc_ast/src/ast/literal.rs Removes field_order attribute and consolidates estree configuration
crates/oxc_ast/src/ast/comment.rs Removes field_order attribute while preserving other estree options

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

graphite-app bot pushed a commit that referenced this pull request Sep 26, 2025
)

`span` is now automatically moved to be last field, so no need to specify field orders explicitly here.
@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from dc6b90b to ff24615 Compare September 26, 2025 09:09
graphite-app bot pushed a commit that referenced this pull request Sep 26, 2025
)

`span` is now automatically moved to be last field, so no need to specify field orders explicitly here.
@graphite-app graphite-app bot force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from ff24615 to fd299aa Compare September 26, 2025 09:10
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Sep 26, 2025
)

`span` is now automatically moved to be last field, so no need to specify field orders explicitly here.
@overlookmotel overlookmotel force-pushed the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch from fd299aa to 6fffdf9 Compare September 26, 2025 09:35
@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Sep 26, 2025
@graphite-app graphite-app bot merged commit 6fffdf9 into main Sep 26, 2025
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 26, 2025
@graphite-app graphite-app bot deleted the 09-26-refactor_ast_remove_unneccesary_estree_field_order_attrs branch September 26, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants