-
-
Notifications
You must be signed in to change notification settings - Fork 720
refactor(ast): remove unneccesary #[estree(field_order)] attrs
#14143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast): remove unneccesary #[estree(field_order)] attrs
#14143
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #14143 will not alter performanceComparing Summary
|
9adceab to
0a9473d
Compare
e185797 to
a394e91
Compare
a394e91 to
38caec5
Compare
Merge activity
|
38caec5 to
dc6b90b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Removes unnecessary #[estree(field_order)] attributes from AST struct definitions since the span field is now automatically moved to be the last field.
- Removes explicit field ordering declarations from estree attributes
- Simplifies estree attribute configurations by removing redundant field_order specifications
- Updates field ordering in
add_fieldsto match automatic span positioning
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_ast/src/ast/ts.rs | Removes field_order attribute and reorders add_fields parameters |
| crates/oxc_ast/src/ast/literal.rs | Removes field_order attribute and consolidates estree configuration |
| crates/oxc_ast/src/ast/comment.rs | Removes field_order attribute while preserving other estree options |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dc6b90b to
ff24615
Compare
ff24615 to
fd299aa
Compare
fd299aa to
6fffdf9
Compare

spanis now automatically moved to be last field, so no need to specify field orders explicitly here.