Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 14, 2025

Enables the linter codegen to recognize code like let foo = node.kind().as_ast_kind() else { return }; and generate the relevant AST kinds.

Screenshot 2025-10-13 at 11 30 46 PM

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 14, 2025
Copy link
Member Author

camchenry commented Oct 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry force-pushed the 10-13-perf_linter_support_as__for_node_type_codegen branch from 985e304 to 50cf70c Compare October 14, 2025 03:21
@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 041b2be to 47481cf Compare October 14, 2025 03:21
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #14582 will not alter performance

Comparing 10-13-perf_linter_support_as__for_node_type_codegen (463be73) with main (cf9f56c)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (463be73) during the generation of this report, so cf9f56c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 47481cf to e1c5fe2 Compare October 14, 2025 03:23
@camchenry camchenry force-pushed the 10-13-perf_linter_support_as__for_node_type_codegen branch 2 times, most recently from 114ad11 to 2458cda Compare October 14, 2025 03:25
@camchenry camchenry force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch 2 times, most recently from ec8228f to 89cb41e Compare October 14, 2025 03:29
@camchenry camchenry force-pushed the 10-13-perf_linter_support_as__for_node_type_codegen branch from 2458cda to d1f1f6f Compare October 14, 2025 03:29
@camchenry camchenry marked this pull request as ready for review October 14, 2025 03:32
@camchenry camchenry requested a review from camc314 as a code owner October 14, 2025 03:32
@camc314 camc314 changed the base branch from 10-13-perf_linter_use_top-level_match_for_const-comparisons_ to graphite-base/14582 October 14, 2025 08:13
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 14, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Oct 14, 2025
Enables the linter codegen to recognize code like `let foo = node.kind().as_ast_kind() else { return };` and generate the relevant AST kinds.

<img width="724" height="429" alt="Screenshot 2025-10-13 at 11 30 46 PM" src="https://github.com/user-attachments/assets/8b71b44a-c22a-48c4-80c7-6d96f4960ca0" />
@graphite-app graphite-app bot force-pushed the 10-13-perf_linter_support_as__for_node_type_codegen branch from d1f1f6f to 573cc39 Compare October 14, 2025 08:18
@github-actions github-actions bot added A-parser Area - Parser A-minifier Area - Minifier A-ast-tools Area - AST tools A-formatter Area - Formatter labels Oct 14, 2025
@graphite-app graphite-app bot changed the base branch from graphite-base/14582 to 10-13-perf_linter_use_top-level_match_for_const-comparisons_ October 14, 2025 08:19
Enables the linter codegen to recognize code like `let foo = node.kind().as_ast_kind() else { return };` and generate the relevant AST kinds.

<img width="724" height="429" alt="Screenshot 2025-10-13 at 11 30 46 PM" src="https://github.com/user-attachments/assets/8b71b44a-c22a-48c4-80c7-6d96f4960ca0" />
@graphite-app graphite-app bot force-pushed the 10-13-perf_linter_use_top-level_match_for_const-comparisons_ branch from 9e3c128 to 8df1e24 Compare October 14, 2025 08:21
@graphite-app graphite-app bot force-pushed the 10-13-perf_linter_support_as__for_node_type_codegen branch from 573cc39 to 463be73 Compare October 14, 2025 08:22
Base automatically changed from 10-13-perf_linter_use_top-level_match_for_const-comparisons_ to main October 14, 2025 08:25
@graphite-app graphite-app bot merged commit 463be73 into main Oct 14, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-13-perf_linter_support_as__for_node_type_codegen branch October 14, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools A-formatter Area - Formatter A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants