Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 14, 2025

Enables skipping by node type. Marginally faster for files that don't contain a class.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 14, 2025
Copy link
Member Author

camchenry commented Oct 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #14578 will not alter performance

Comparing 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols (676ee99) with main (454ee94)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (676ee99) during the generation of this report, so 454ee94 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry marked this pull request as ready for review October 14, 2025 03:23
@camchenry camchenry requested a review from camc314 as a code owner October 14, 2025 03:23
Copilot AI review requested due to automatic review settings October 14, 2025 03:23
@camchenry camchenry force-pushed the 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols branch from e5d03c5 to a5e3c7f Compare October 14, 2025 03:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the no-class-assign linter rule by changing it to run on class nodes instead of symbols, enabling better performance for files without classes.

  • Changes the rule implementation from run_on_symbol to run method with early return for non-class nodes
  • Adds explicit class node filtering and symbol ID extraction
  • Includes debug assertion to verify symbol table consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 15, 2025
Copy link
Contributor

camc314 commented Oct 15, 2025

Merge activity

…#14578)

Enables skipping by node type. Marginally faster for files that don't contain a class.
@graphite-app graphite-app bot force-pushed the 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols branch from bce4941 to 676ee99 Compare October 15, 2025 09:09
@graphite-app graphite-app bot merged commit 676ee99 into main Oct 15, 2025
20 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 15, 2025
@graphite-app graphite-app bot deleted the 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols branch October 15, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants