-
-
Notifications
You must be signed in to change notification settings - Fork 708
perf(linter): run no-class-assign on class nodes instead of symbols
#14578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(linter): run no-class-assign on class nodes instead of symbols
#14578
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #14578 will not alter performanceComparing Summary
Footnotes
|
e5d03c5 to
a5e3c7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR optimizes the no-class-assign linter rule by changing it to run on class nodes instead of symbols, enabling better performance for files without classes.
- Changes the rule implementation from
run_on_symboltorunmethod with early return for non-class nodes - Adds explicit class node filtering and symbol ID extraction
- Includes debug assertion to verify symbol table consistency
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a5e3c7f to
73d5e1b
Compare
73d5e1b to
bce4941
Compare
Merge activity
|
…#14578) Enables skipping by node type. Marginally faster for files that don't contain a class.
bce4941 to
676ee99
Compare

Enables skipping by node type. Marginally faster for files that don't contain a class.