Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 15, 2025

Returning () in the wildcard of a match block like match node.kind() { ... } is effectively the same as _ => {}, we just didn't support this syntax yet.

+1-2% on the linter benchmarks.

Screenshot 2025-10-14 at 11 51 51 PM

Copy link
Member Author

camchenry commented Oct 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #14611 will not alter performance

Comparing 10-14-perf_linter_update_linter_codegen_to_support_wildcard_with_empty_tuple (48e3348) with main (676ee99)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (90f5f89) during the generation of this report, so 676ee99 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camchenry camchenry marked this pull request as ready for review October 15, 2025 03:57
@camchenry camchenry requested a review from camc314 as a code owner October 15, 2025 03:57
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025

Merge activity

…ple (#14611)

Returning `()` in the wildcard of a match block like `match node.kind() { ... }` is effectively the same as `_ => {}`, we just didn't support this syntax yet.

+1-2% on the linter benchmarks.

<img width="717" height="373" alt="Screenshot 2025-10-14 at 11 51 51 PM" src="https://github.com/user-attachments/assets/5c5b03f0-15b2-4a2f-b7e5-ab57c61634b5" />
@graphite-app graphite-app bot force-pushed the 10-14-refactor_linter_remove_run_on_symbol_ branch from 41974d1 to 90f5f89 Compare October 15, 2025 09:18
@graphite-app graphite-app bot force-pushed the 10-14-perf_linter_update_linter_codegen_to_support_wildcard_with_empty_tuple branch from 47b09dd to 48e3348 Compare October 15, 2025 09:18
Base automatically changed from 10-14-refactor_linter_remove_run_on_symbol_ to main October 15, 2025 09:23
@graphite-app graphite-app bot merged commit 48e3348 into main Oct 15, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-14-perf_linter_update_linter_codegen_to_support_wildcard_with_empty_tuple branch October 15, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants