Skip to content

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 15, 2025

Allows optimization based on node types. Also slightly less code as we don't need to traverse ancestors as much anymore.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 15, 2025
Copy link
Member Author

camchenry commented Oct 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry force-pushed the 10-14-perf_linter_switch_no-param-reassign_to_run_on_nodes branch from 49441bf to 4f2d2d5 Compare October 15, 2025 02:14
@camchenry camchenry force-pushed the 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols branch from 73d5e1b to bce4941 Compare October 15, 2025 02:16
@camchenry camchenry force-pushed the 10-14-perf_linter_switch_no-param-reassign_to_run_on_nodes branch from 4f2d2d5 to f54d7d4 Compare October 15, 2025 02:16
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #14604 will not alter performance

Comparing 10-14-perf_linter_switch_no-param-reassign_to_run_on_nodes (c821c50) with main (676ee99)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (c821c50) during the generation of this report, so 676ee99 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot changed the base branch from 10-13-perf_linter_run_no-class-assign_on_class_nodes_instead_of_symbols to graphite-base/14604 October 15, 2025 09:09
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/14604 to main October 15, 2025 09:15
Allows optimization based on node types. Also slightly less code as we don't need to traverse ancestors as much anymore.
@graphite-app graphite-app bot force-pushed the 10-14-perf_linter_switch_no-param-reassign_to_run_on_nodes branch from f54d7d4 to c821c50 Compare October 15, 2025 09:16
@graphite-app graphite-app bot merged commit c821c50 into main Oct 15, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 10-14-perf_linter_switch_no-param-reassign_to_run_on_nodes branch October 15, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants