-
-
Notifications
You must be signed in to change notification settings - Fork 715
feat(editor): support oxc.fmt.configPath configuration
#14639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): support oxc.fmt.configPath configuration
#14639
Conversation
049aef7 to
be35392
Compare
bbcabc2 to
d0aba11
Compare
be35392 to
9a2df8d
Compare
d0aba11 to
4995f5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the oxc.fmt.configPath configuration option, allowing users to specify a custom path to an oxfmt configuration file for formatting operations. When set to null, the formatter defaults to using .oxfmtrc.json at the workspace root.
Key changes:
- Added
oxc.fmt.configPathconfiguration option to VS Code extension settings - Implemented configuration handling in
WorkspaceConfigclass with getter/setter methods - Added E2E test demonstrating formatting with a custom config file path
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/package.json | Adds oxc.fmt.configPath configuration schema with string or null type |
| editors/vscode/client/WorkspaceConfig.ts | Implements config path property, getter/setter methods, and language server serialization |
| editors/vscode/tests/WorkspaceConfig.spec.ts | Adds test coverage for the new config path property |
| editors/vscode/tests/e2e_server.spec.ts | Adds E2E test and teardown for formatting with custom config path |
| editors/vscode/README.md | Documents the new configuration option |
| editors/vscode/fixtures/formatting_with_config/formatting.ts | Test fixture file for formatting test |
| editors/vscode/fixtures/formatting_with_config/formatter.json | Test config file with semicolons setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9a2df8d to
426f7e5
Compare
55fd06f to
b4880dc
Compare
b4880dc to
65faf92
Compare
Merge activity
|
Now, the VSCode editor supports `oxc.fmt.configPath` to communicate with the server. Other Editors could use it already, waited for the "watch" feature to implement it in VSCode :)
65faf92 to
8b322d4
Compare

Now, the VSCode editor supports
oxc.fmt.configPathto communicate with the server.Other Editors could use it already, waited for the "watch" feature to implement it in VSCode :)