refactor(language_server): move Diagnostics-map to WorkspaceWorker

[Sysix]

No description provided.

[Sysix]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(editor): add off to oxc.lint.run configuration #14755
• refactor(language_server): move Diagnostics-map to WorkspaceWorker #14830 👈 (View in Graphite)
• feat(language_server): able to set off for run configuration #14746
• refactor(language_server): improve file watching for different tools #14645
• feat(editor): support oxc.fmt.configPath configuration #14639
• feat(language_server): watch for fmt.configPath file content change #14509
• test(language_server): add basic tests for WorkspaceWorker::did_change_configuration #14531
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors the diagnostic management in the language server by moving the Diagnostics map from ServerLinter to WorkspaceWorker. This change centralizes diagnostic storage at the workspace level and removes async requirements from several diagnostic-related methods.

Key Changes:

• Introduced WorkerDiagnostics struct to manage diagnostic maps at the workspace level
• Removed ServerLinterDiagnostics from ServerLinter and associated diagnostic management methods
• Converted async diagnostic methods to synchronous ones where possible

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_language_server/src/worker.rs	Added WorkerDiagnostics struct and integrated it into WorkspaceWorker; moved diagnostic management methods from ServerLinter; converted several async methods to sync
crates/oxc_language_server/src/linter/server_linter.rs	Removed ServerLinterDiagnostics struct and its methods; updated run_single and revalidate_diagnostics to accept WorkerDiagnostics parameter; moved test case to worker.rs
crates/oxc_language_server/src/backend.rs	Updated method calls to use synchronous versions of get_clear_diagnostics and remove_diagnostics

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The dedup() method only removes consecutive duplicates from a sorted vector. If a file exists in both isolated_files and tsgo_files but they are not adjacent after extending, duplicates will remain. Consider sorting before calling dedup(), or use a HashSet to ensure all duplicates are removed: files.sort(); files.dedup();

Suggested change

	files.extend(tsgo_files);
	files.extend(tsgo_files);
	files.sort();

[Copilot]

The conditional check if let Some(linter_files) = linter_files was removed, but linter_files is now a Vec<Uri> that is always returned (never Option). This changes the behavior: when the linter was previously None, no revalidation occurred. Now get_cached_files_of_diagnostics() returns an empty vector, and revalidate_diagnostics is called with that empty vector. While functionally similar, this adds an unnecessary function call. Consider adding back a check: if !linter_files.is_empty() { diagnostics = Some(self.revalidate_diagnostics(linter_files).await); }

Suggested change

	diagnostics = Some(self.revalidate_diagnostics(linter_files).await);
	if !linter_files.is_empty() {
	diagnostics = Some(self.revalidate_diagnostics(linter_files).await);
	}

[Sysix]

This is the wrong approach, you can open files while no new diagnostics are added/removed.