perf(linter): add codegen support for is_member_expression_kind in match

[camchenry]

is_member_expression_kind is a known method that has a fixed number of AST variants that it will return true for. We already parse this out at the beginning of linter codegen, so we know what variants this will check for. So, we can extend the node types instead of simply bailing out early.

[camchenry]

• perf(linter): add codegen support for is_member_expression_kind in match #14677 : 2 dependent PRs (#14678 , #14687 ) 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #14677 will not alter performance

_{Comparing 10-16-perf_linter_add_codegen_support_for_is_member_expression_kind_in_match (f830bea) with main (5ea3bb6)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

Footnotes

1. No successful run was found on main (f830bea) during the generation of this report, so 5ea3bb6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull Request Overview

This PR enhances the linter codegen by adding support for detecting is_member_expression_kind method calls in match expressions. The improvement allows the codegen to recognize when a rule uses this specific method and automatically include the relevant member expression AST variants in the node type set, rather than falling back to incomplete collection.

Key changes:

• Extended MatchDetector to handle is_member_expression_kind guard expressions in match arms
• Added dependency on RuleRunnerData to access pre-parsed member expression kinds
• Modified the detection logic to recognize and process this specific pattern

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
tasks/linter_codegen/src/match_detector.rs	Added lifetime parameter, RuleRunnerData dependency, and new pattern matching for is_member_expression_kind method calls
tasks/linter_codegen/src/main.rs	Updated function call to pass rule_runner_data parameter to MatchDetector::from_run_func

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[graphite-app]

Merge activity

• Oct 17, 10:20 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Oct 17, 10:25 AM UTC: Merged by the Graphite merge queue.