- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 710
 
          perf(linter): update no-extra-non-null-assertion to use diverging match
          #14697
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            graphite-app
  merged 1 commit into
  main
from
10-16-perf_linter_update_no-extra-non-null-assertion_to_use_diverging_match
  
      
      
   
  Oct 17, 2025 
      
    
                
     Merged
            
            
  
    perf(linter): update no-extra-non-null-assertion to use diverging match
  
  #14697
              
                    graphite-app
  merged 1 commit into
  main
from
10-16-perf_linter_update_no-extra-non-null-assertion_to_use_diverging_match
  
      
      
   
  Oct 17, 2025 
              
            
      
        
          +7
        
        
          −2
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
  This was referenced Oct 17, 2025 
      
      
     Merged
  
  This was referenced Oct 17, 2025 
      
          
CodSpeed Performance ReportMerging #14697 will not alter performanceComparing  Summary
 Footnotes
  | 
    
              
                    camc314
  
              
              approved these changes
              
                  
                    Oct 17, 2025 
                  
              
              
            
            
          Merge activity
  | 
    
…atch (#14697) Adding the diverging match here enables the linter codegen to recognize this pattern and do node type analysis.
acf5f00    to
    231bac0      
    Compare
  
    fd9da94    to
    2582a50      
    Compare
  
        
          Base automatically changed from
    
      10-16-perf_linter_update_typescript_array-type_to_only_have_top-level_match
     to
    
      main
    
    October 17, 2025 10:43     
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-linter
  Area - Linter 
  
    C-performance
  Category - Solution not expected to change functional behavior, only performance 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Adding the diverging match here enables the linter codegen to recognize this pattern and do node type analysis.