Skip to content

fix(formatter): correct handling of leading own line before arrow function body #14877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(formatter): correct handling of leading own line before arrow function body #14877

merged 1 commit into from
Oct 22, 2025
+33 −8

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 22, 2025 •
edited
Loading

close: #14871

@github-actions github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Oct 22, 2025
@Dunqing Dunqing mentioned this pull request Oct 22, 2025
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Oct 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Oct 22, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 22, 2025

CodSpeed Performance Report

Merging #14877 will not alter performance

Comparing 10-22-fix_formatter_correct_handling_of_leading_own_line_before_arrow_function_body (2f8d1fa) with 10-21-fix_formatter_correct_printing_trailing_comments_for_if_statement_with_non-block_consequent (c9d4b51)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This was referenced Oct 22, 2025
Merged
Merged
Merged
Merged
Merged
@Dunqing Dunqing marked this pull request as ready for review October 22, 2025 07:15
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 10-21-fix_formatter_correct_printing_trailing_comments_for_if_statement_with_non-block_consequent branch from c9d4b51 to 4a499b5 Compare October 22, 2025 07:34
@graphite-app graphite-app bot force-pushed the 10-22-fix_formatter_correct_handling_of_leading_own_line_before_arrow_function_body branch from 2f8d1fa to 990916a Compare October 22, 2025 07:34
Base automatically changed from 10-21-fix_formatter_correct_printing_trailing_comments_for_if_statement_with_non-block_consequent to main October 22, 2025 07:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
@graphite-app graphite-app bot merged commit 990916a into main Oct 22, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-22-fix_formatter_correct_handling_of_leading_own_line_before_arrow_function_body branch October 22, 2025 07:41
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
graphite-app bot pushed a commit that referenced this pull request Oct 22, 2025
@Boshen
release(oxfmt): v0.8.0 (#14889)
646c2ab 
## [0.8.0] - 2025-10-22

### 🚀 Features

- 381e08c oxfmt: More friendly JSON schema (#14879) (leaysgur)
- 006708d oxfmt: Support `ignorePatterns` in oxfmtrc (#14875) (leaysgur)

### 🐛 Bug Fixes

- 64b8226 formatter: Corrct printing leading own line comments before method body (#14886) (Dunqing)
- 6ce1162 formatter: Remove a redundant space for TSMappedType (#14885) (Dunqing)
- 5b962a7 formatter: Remove redundant leading space when only the rest part of the array exists (#14884) (Dunqing)
- 8301d8f formatter: No need to wrap parenthesis for ObjectExpression when it is an expression of a template literal (#14883) (Dunqing)
- 9397472 formatter: Should not wrap parenthesis for ComputedMemberExpression when it is not an option or it doesn't contain a call expression (#14882) (Dunqing)
- 3e62277 formatter: Should not add a soft line for the arrow function inside ExpressionContainer with a trailing comment (#14878) (Dunqing)
- 990916a formatter: Correct handling of leading own line before arrow function body (#14877) (Dunqing)
- 4a499b5 formatter: Correct printing trailing comments for if statement with non-block consequent (#14857) (Dunqing)

### 🧪 Testing

- 868ff99 formatter: Fix tests using TS syntax with `.js` (#14880) (leaysgur)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

formatter: Descrency between Prettier and OxFmt

2 participants

@Dunqing