-
-
Notifications
You must be signed in to change notification settings - Fork 711
test(formatter): Fix tests using TS syntax with .js
#14880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(formatter): Fix tests using TS syntax with .js
#14880
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
.js
|
For // ORIGINAL
function *t1() {
yield (
// comment
a
);
}
// Oxc
function* t1() {
yield (
// comment
a
);
}
// Prettier
function* t1() {
yield // comment
a;
}
// Biome
function* t1() {
yield// comment
a;
}I'm not sure it might just be a known issue, so I'll leave this to you. 🙏🏻 |
|
For the |
It is expected, and probably a bug in the |
As I noted top comment, there is already So, is it OK to remove |
Oh, sorry, I overlooked. Now it is okay to remove. |
229b2be to
5442349
Compare
a0daa6a to
839688e
Compare
|
Removed. Now let me merge the stack. 🕺🏻 |
Merge activity
|
839688e to
fe1a101
Compare
5442349 to
381e08c
Compare
fe1a101 to
faec008
Compare
As a result, it caused a parsing error, and nothing was recorded. 🙈 - tests/fixtures/js/comments/yield.js - Removed, the same test already exists in ts/comments/yield.ts - tests/fixtures/js/comments/assignments.js - Removed TS syntax - tests/fixtures/ts/comments/assignments.ts - The same as original js/comments/assignment.js
faec008 to
868ff99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
## [0.8.0] - 2025-10-22 ### 🚀 Features - 381e08c oxfmt: More friendly JSON schema (#14879) (leaysgur) - 006708d oxfmt: Support `ignorePatterns` in oxfmtrc (#14875) (leaysgur) ### 🐛 Bug Fixes - 64b8226 formatter: Corrct printing leading own line comments before method body (#14886) (Dunqing) - 6ce1162 formatter: Remove a redundant space for TSMappedType (#14885) (Dunqing) - 5b962a7 formatter: Remove redundant leading space when only the rest part of the array exists (#14884) (Dunqing) - 8301d8f formatter: No need to wrap parenthesis for ObjectExpression when it is an expression of a template literal (#14883) (Dunqing) - 9397472 formatter: Should not wrap parenthesis for ComputedMemberExpression when it is not an option or it doesn't contain a call expression (#14882) (Dunqing) - 3e62277 formatter: Should not add a soft line for the arrow function inside ExpressionContainer with a trailing comment (#14878) (Dunqing) - 990916a formatter: Correct handling of leading own line before arrow function body (#14877) (Dunqing) - 4a499b5 formatter: Correct printing trailing comments for if statement with non-block consequent (#14857) (Dunqing) ### 🧪 Testing - 868ff99 formatter: Fix tests using TS syntax with `.js` (#14880) (leaysgur)

As a result, it caused a parsing error, and nothing was recorded. 🙈