fix(formatter): correct printing trailing comments for if statement with non-block consequent #14857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the formatting of trailing comments for if statements with non-block consequents. The formatter previously incorrectly handled trailing comments when they followed certain punctuation characters, causing issues with if statements that have simple expressions or empty statements as their consequent.
Key changes:
- Modified comment position detection logic to handle
=and:characters - Added test cases for if statements with trailing comments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_formatter/src/formatter/comments.rs | Updated byte-matching logic to include = and : characters when detecting comment positions |
| crates/oxc_formatter/tests/fixtures/js/comments/if.js | Added test input with if statements containing trailing comments |
| crates/oxc_formatter/tests/fixtures/js/comments/if.js.snap | Added expected output snapshot for the test cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Performance ReportMerging #14857 will not alter performanceComparing Summary
Footnotes
|
This was referenced Oct 22, 2025
Merged
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
10-21-fix_formatter_correct_printing_trailing_comments_for_if_statement_with_non-block_consequent
branch
from
c9d4b51 to
4a499b5
Compare
graphite-app
bot
deleted the
10-21-fix_formatter_correct_printing_trailing_comments_for_if_statement_with_non-block_consequent
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
## [0.8.0] - 2025-10-22 ### 🚀 Features - 381e08c oxfmt: More friendly JSON schema (#14879) (leaysgur) - 006708d oxfmt: Support `ignorePatterns` in oxfmtrc (#14875) (leaysgur) ### 🐛 Bug Fixes - 64b8226 formatter: Corrct printing leading own line comments before method body (#14886) (Dunqing) - 6ce1162 formatter: Remove a redundant space for TSMappedType (#14885) (Dunqing) - 5b962a7 formatter: Remove redundant leading space when only the rest part of the array exists (#14884) (Dunqing) - 8301d8f formatter: No need to wrap parenthesis for ObjectExpression when it is an expression of a template literal (#14883) (Dunqing) - 9397472 formatter: Should not wrap parenthesis for ComputedMemberExpression when it is not an option or it doesn't contain a call expression (#14882) (Dunqing) - 3e62277 formatter: Should not add a soft line for the arrow function inside ExpressionContainer with a trailing comment (#14878) (Dunqing) - 990916a formatter: Correct handling of leading own line before arrow function body (#14877) (Dunqing) - 4a499b5 formatter: Correct printing trailing comments for if statement with non-block consequent (#14857) (Dunqing) ### 🧪 Testing - 868ff99 formatter: Fix tests using TS syntax with `.js` (#14880) (leaysgur)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed caused by #14816.