fix(formatter): should not add a trailing comma for long curried calls when `trailingComma` is es5 #14913

Dunqing · 2025-10-23T02:13:01Z

No description provided.

Dunqing · 2025-10-23T02:13:16Z

fix(formatter): correct calculating layout for ChainExpression in StaticMemberExpression #14986
fix(formatter): should not break when the parent of root of StaticMemberExpression is used as the Argument of NewExpression #14985
fix(formatter): align the short argument handling for UnaryExpression with Prettier #14984
fix(formatter): BestFitting doesn't exactly matches the conditinalGroup behavior in Prettier #14983
fix(formatter): align the logic of printing type parameters, parameters, and return type for functions with Prettier #14942
refactor(formatter): clean up unneeded implementations for printing comments #14935
refactor(formatter): improve printing trailing comments #14934
fix(formatter): non-nested static member expressions will never break #14929
fix(formatter): check whether a type alias is complex when its right hand side never break #14928
refactor(formatter): align printing trailing comments with Prettier #14927
fix(formatter): should not add a trailing comma for long curried calls when trailingComma is es5 #14913 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-23T02:18:08Z

CodSpeed Performance Report

Merging #14913 will not alter performance

_{Comparing 10-23-fix_formatter_should_not_add_a_trailing_comma_for_long_curried_calls_when_trailingcomma_is_es5 (48e65dd) with main (bd74603)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

No successful run was found on main (272a145) during the generation of this report, so bd74603 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

This PR fixes a bug in the formatter where trailing commas were incorrectly added to long curried function calls when the trailingComma option was set to "es5". The ES5 specification does not support trailing commas in function arguments, so they should only be added when trailingComma is set to "all".

Key changes:

Updated the formatter logic to respect the trailingComma configuration option for long curried calls
Added test fixtures to verify correct behavior across all three trailingComma modes: "none", "es5", and "all"

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_formatter/src/write/call_arguments.rs	Fixed trailing comma logic to use the configured option instead of always using "all"
crates/oxc_formatter/tests/fixtures/js/arguments/long-curried-call/trailing-comma.js	Added test input demonstrating a long curried call
crates/oxc_formatter/tests/fixtures/js/arguments/long-curried-call/options.json	Added test configuration for all three trailing comma modes
crates/oxc_formatter/tests/fixtures/js/arguments/long-curried-call/trailing-comma.js.snap	Added expected test output showing correct behavior for each mode

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_formatter/src/write/call_arguments.rs

graphite-app · 2025-10-27T09:32:23Z

Merge activity

Oct 27, 9:32 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Oct 27, 9:39 AM UTC: Merged by the Graphite merge queue.

…s when `trailingComma` is es5 (#14913)

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) ### 💼 Other - aceff66 oxfmt: V0.9.0 (#15088) (Boshen)

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) ### 💼 Other - 6368793 oxfmt: V0.9.0 (#15091) (Boshen) - aceff66 oxfmt: V0.9.0 (#15088) (Boshen)

github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Oct 23, 2025

Dunqing force-pushed the 10-23-fix_formatter_should_not_add_a_trailing_comma_for_long_curried_calls_when_trailingcomma_is_es5 branch from 32e2496 to 48e65dd Compare October 24, 2025 02:12

Dunqing mentioned this pull request Oct 24, 2025

refactor(formatter): align printing trailing comments with Prettier #14927

Merged

Dunqing marked this pull request as ready for review October 24, 2025 02:16

Copilot AI review requested due to automatic review settings October 24, 2025 02:16

Copilot AI reviewed Oct 24, 2025

View reviewed changes

crates/oxc_formatter/src/write/call_arguments.rs Show resolved Hide resolved

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025

fix(formatter): should not add a trailing comma for long curried call…

e501f13

…s when `trailingComma` is es5 (#14913)

graphite-app bot force-pushed the 10-23-fix_formatter_should_not_add_a_trailing_comma_for_long_curried_calls_when_trailingcomma_is_es5 branch from 48e65dd to e501f13 Compare October 27, 2025 09:32

graphite-app bot merged commit e501f13 into main Oct 27, 2025
20 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 27, 2025

graphite-app bot deleted the 10-23-fix_formatter_should_not_add_a_trailing_comma_for_long_curried_calls_when_trailingcomma_is_es5 branch October 27, 2025 09:39

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15088

Merged

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15091

Merged

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15096

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(formatter): should not add a trailing comma for long curried calls when `trailingComma` is es5 #14913

fix(formatter): should not add a trailing comma for long curried calls when `trailingComma` is es5 #14913

Dunqing commented Oct 23, 2025

Uh oh!

Dunqing commented Oct 23, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 23, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(formatter): should not add a trailing comma for long curried calls when trailingComma is es5 #14913

fix(formatter): should not add a trailing comma for long curried calls when trailingComma is es5 #14913

Conversation

Dunqing commented Oct 23, 2025

Uh oh!

Dunqing commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14913 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

graphite-app bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(formatter): should not add a trailing comma for long curried calls when `trailingComma` is es5 #14913

fix(formatter): should not add a trailing comma for long curried calls when `trailingComma` is es5 #14913

Dunqing commented Oct 23, 2025 •

edited

Loading

codspeed-hq bot commented Oct 23, 2025 •

edited

Loading

graphite-app bot commented Oct 27, 2025 •

edited

Loading