fix(formatter): correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` #15065

Dunqing · 2025-10-29T10:35:18Z

No description provided.

Dunqing · 2025-10-29T10:35:41Z

perf(formatter): optimize grouping logic for call arguments #15033
fix(formatter): correct calculating layout for TSNonNullExpression in StaticMemberExpression #15065 👈 (View in Graphite)
fix(formatter): print parenthesis for sequence expression in ReturnStatement and ExpressionStatement #15062
fix(formatter): correct printing comments for TSAsExpression #15061
fix(formatter): correct checking of the short argument for CallArguments #15055
fix(formatter): print comments before fat arrow as-is for ArrowFunctionExpression #15050
fix(formatter): should hug parameter with TSMappedType type annotation #15049
fix(formatter): incorrect formatting of a function with this parameter #15031
refactor(formatter): simplify printing ClassElement with a semicolon #15030
fix(formatter): decorators and class method on the same line shouldn't be broken by a leading comment of the method #15029
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-29T10:40:41Z

CodSpeed Performance Report

Merging #15065 will not alter performance

_{Comparing 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression (673a357) with main (206b519)¹}

Summary

✅ 33 untouched
⏩ 4 skipped²

No successful run was found on 10-29-fix_formatter_print_parenthesis_for_sequence_expression_in_returnstatement_and_expressionstatement (3c70a06) during the generation of this report, so main (206b519) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Dunqing · 2025-10-29T15:45:37Z

@leaysgur, Hi, I am going to merge this stack without reviewing because we will cut a release tomorrow after I review and merge #14820. This will help avoid a lot of PRs being merged at the same time. I hope you don't mind; feel free to review it later!

Dunqing · 2025-10-29T15:45:59Z

Merge activity

Oct 29, 3:45 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 29, 3:46 PM UTC: Dunqing added this pull request to the Graphite merge queue.
Oct 29, 3:46 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #15062.
Oct 30, 12:36 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Oct 30, 12:45 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 30, 12:45 AM UTC: leaysgur added this pull request to the Graphite merge queue.
Oct 30, 12:45 AM UTC: Merged by the Graphite merge queue.

…in `StaticMemberExpression` (#15065)

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) Co-authored-by: leaysgur <6259812+leaysgur@users.noreply.github.com>

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) ### 💼 Other - aceff66 oxfmt: V0.9.0 (#15088) (Boshen)

## [0.9.0] - 2025-10-30 ### 🚀 Features - 8fe7e85 formatter: Support printing Formatter IR (#14855) (Dunqing) ### 🐛 Bug Fixes - a6b6ef8 formatter: Correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` (#15065) (Dunqing) - 99bd995 formatter: Print parenthesis for sequence expression in `ReturnStatement` and `ExpressionStatement` (#15062) (Dunqing) - f3fb998 formatter: Correct printing comments for `TSAsExpression` (#15061) (Dunqing) - 1e4a018 formatter: Correct checking of the short argument for `CallArguments` (#15055) (Dunqing) - c0dfd9b formatter: Print comments before fat arrow as-is for `ArrowFunctionExpression` (#15050) (Dunqing) - 206b519 formatter: Should hug parameter with `TSMappedType` type annotation (#15049) (Dunqing) - e48c604 formatter: Incorrect formatting of a function with `this` parameter (#15031) (Dunqing) - a9f0c45 formatter: Decorators and class method on the same line shouldn't be broken by a leading comment of the method (#15029) (Dunqing) - 43d74e4 formatter: Handle `<CRLF>` for `SourceText` (#15016) (leaysgur) - 34fab40 formatter: Correct calculating layout for `ChainExpression` in `StaticMemberExpression` (#14986) (Dunqing) - 68dc101 formatter: Should not break when the parent of root of `StaticMemberExpression` is used as the `Argument` of `NewExpression` (#14985) (Dunqing) - 071b739 formatter: Align the short argument handling for UnaryExpression with Prettier (#14984) (Dunqing) - 3940f3a formatter: `BestFitting` doesn't exactly matches the `conditinalGroup` behavior in Prettier (#14983) (Dunqing) - 4a84e44 formatter: Align the logic of printing type parameters, parameters, and return type for functions with Prettier (#14942) (Dunqing) - 68c1f2a formatter: Non-nested static member expressions will never break (#14929) (Dunqing) - 42adc47 formatter: Check whether a type alias is complex when its right hand side never break (#14928) (Dunqing) - e501f13 formatter: Should not add a trailing comma for long curried calls when `trailingComma` is es5 (#14913) (Dunqing) ### 🚜 Refactor - 7d64291 formatter: Simplify printing ClassElement with a semicolon (#15030) (Dunqing) - 5de99c2 formatter: Export unified way to get_parse_options (#15027) (leaysgur) - f6f22e2 formatter: Clean up unneeded implementations for printing comments (#14935) (Dunqing) - 7a2b9d1 formatter: Improve printing trailing comments (#14934) (Dunqing) - ba10caa formatter: Align printing trailing comments with Prettier (#14927) (Dunqing) - 597c9e8 formatter: Remove redundunt public API (#14915) (leaysgur) ### ⚡ Performance - 467b3a1 formatter: Optimize grouping logic for call arguments (#15033) (Dunqing) ### 💼 Other - 6368793 oxfmt: V0.9.0 (#15091) (Boshen) - aceff66 oxfmt: V0.9.0 (#15088) (Boshen)

github-actions bot added A-formatter Area - Formatter C-bug Category - Bug labels Oct 29, 2025

This was referenced Oct 29, 2025

fix(formatter): correct printing comments for TSAsExpression #15061

Merged

fix(formatter): print parenthesis for sequence expression in ReturnStatement and ExpressionStatement #15062

Merged

Dunqing marked this pull request as ready for review October 29, 2025 10:36

Dunqing assigned leaysgur Oct 29, 2025

Dunqing requested a review from leaysgur October 29, 2025 15:32

Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025

Dunqing force-pushed the 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression branch from 02f25fa to 673a357 Compare October 29, 2025 16:33

Dunqing force-pushed the 10-29-fix_formatter_print_parenthesis_for_sequence_expression_in_returnstatement_and_expressionstatement branch from c0ce817 to 3c70a06 Compare October 29, 2025 16:33

Dunqing mentioned this pull request Oct 29, 2025

perf(formatter): optimize grouping logic for call arguments #15033

Merged

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Oct 29, 2025

graphite-app bot force-pushed the 10-29-fix_formatter_print_parenthesis_for_sequence_expression_in_returnstatement_and_expressionstatement branch from 3c70a06 to 06daabe Compare October 30, 2025 00:01

graphite-app bot force-pushed the 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression branch from 673a357 to 898ff76 Compare October 30, 2025 00:01

fix(formatter): correct calculating layout for TSNonNullExpression …

a6b6ef8

…in `StaticMemberExpression` (#15065)

graphite-app bot force-pushed the 10-29-fix_formatter_print_parenthesis_for_sequence_expression_in_returnstatement_and_expressionstatement branch from 06daabe to 99bd995 Compare October 30, 2025 00:37

graphite-app bot force-pushed the 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression branch from 898ff76 to a6b6ef8 Compare October 30, 2025 00:37

Base automatically changed from 10-29-fix_formatter_print_parenthesis_for_sequence_expression_in_returnstatement_and_expressionstatement to main October 30, 2025 00:42

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025

leaysgur added the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025

leaysgur approved these changes Oct 30, 2025

View reviewed changes

graphite-app bot merged commit a6b6ef8 into main Oct 30, 2025
21 checks passed

graphite-app bot deleted the 10-29-fix_formatter_correct_calculating_layout_for_tsnonnullexpression_in_staticmemberexpression branch October 30, 2025 00:45

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 30, 2025

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15088

Merged

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15091

Merged

Boshen mentioned this pull request Oct 30, 2025

release(oxfmt): v0.9.0 #15096

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(formatter): correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` #15065

fix(formatter): correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` #15065

Dunqing commented Oct 29, 2025

Uh oh!

Dunqing commented Oct 29, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Dunqing commented Oct 29, 2025

Uh oh!

Dunqing commented Oct 29, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(formatter): correct calculating layout for TSNonNullExpression in StaticMemberExpression #15065

fix(formatter): correct calculating layout for TSNonNullExpression in StaticMemberExpression #15065

Conversation

Dunqing commented Oct 29, 2025

Uh oh!

Dunqing commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15065 will not alter performance

Summary

Footnotes

Uh oh!

Dunqing commented Oct 29, 2025

Uh oh!

Dunqing commented Oct 29, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(formatter): correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` #15065

fix(formatter): correct calculating layout for `TSNonNullExpression` in `StaticMemberExpression` #15065

Dunqing commented Oct 29, 2025 •

edited

Loading

codspeed-hq bot commented Oct 29, 2025 •

edited

Loading

Dunqing commented Oct 29, 2025 •

edited by graphite-app bot

Loading