perf(linter/plugins): use singleton object for ScopeManager
#15332
+88
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 5, 2025
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ScopeManager implementation from a class-based approach to a singleton frozen object pattern, improving performance and memory efficiency.
Key Changes:
- Converted
ScopeManagerfrom a class to a frozen singleton object (SCOPE_MANAGER) - Moved scope manager state management from
source_code.tstoscope.tsfor better encapsulation - Implemented lazy initialization of the underlying TS-ESLint scope manager
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/source_code.ts | Updated imports and removed local scope manager state, delegating to the new SCOPE_MANAGER singleton |
| apps/oxlint/src-js/plugins/scope.ts | Refactored ScopeManager class to a frozen singleton object with lazy initialization and added reset functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
11-05-perf_linter_plugins_use_singleton_object_for_scopemanager_
branch
2 times, most recently
from
75a6a13 to
728ea43
Compare
Contributor
Merge activity
|
Follow-on after #14890. That PR implemented `ScopeManager` class. Instead of a class, which an instance of is created for each file, use a singleton object, with the underlying TS-ESLint scope manager stored in a top-level var. Methods/getters of `SCOPE_MANAGER` lazily initialize the TS-ESLint scope manager as required, and cache it. This pattern is the same as we use for `SourceCode`, enabled by the fact that only 1 file is linted at a time. This has several advantages: 1. Reduce object creation - less GC pressure. 2. Property accesses don't need to go up prototype chain, as they would for instances of a class. 3. No need for private properties, which are somewhat expensive to access.
graphite-app
bot
force-pushed
the
11-05-perf_linter_plugins_use_singleton_object_for_scopemanager_
branch
from
728ea43 to
4c0ba92
Compare
graphite-app
bot
deleted the
11-05-perf_linter_plugins_use_singleton_object_for_scopemanager_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #14890.
That PR implemented
ScopeManagerclass. Instead of a class, which an instance of is created for each file, use a singleton object, with the underlying TS-ESLint scope manager stored in a top-level var. Methods/getters ofSCOPE_MANAGERlazily initialize the TS-ESLint scope manager as required, and cache it.This pattern is the same as we use for
SourceCode, enabled by the fact that only 1 file is linted at a time. This has several advantages: