perf(linter/plugins): small optimizations to ScopeManager
#15334
+20
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
This was referenced Nov 5, 2025
overlookmotel
force-pushed
the
11-05-docs_linter_plugins_reformat_and_clarify_scopemanager_jsdoc_comments
branch
from
542da43 to
e574bfb
Compare
overlookmotel
force-pushed
the
11-05-perf_linter_plugins_small_optimizations_to_scopemanager_
branch
2 times, most recently
from
9682116 to
13cf9c4
Compare
overlookmotel
force-pushed
the
11-05-docs_linter_plugins_reformat_and_clarify_scopemanager_jsdoc_comments
branch
from
e574bfb to
c1b94e0
Compare
Contributor
Merge activity
|
Follow-on after #14890. Small optimizations to `ScopeManager`. * Remove temp vars. * Test vars with `=== null` or `=== undefined` instead of `!`. * Avoid reading out of bounds of arrays. * Get length of array once before loop, rather than on each turn of loop. Also add comments about potential future optimizations.
graphite-app
bot
force-pushed
the
11-05-docs_linter_plugins_reformat_and_clarify_scopemanager_jsdoc_comments
branch
from
c1b94e0 to
a7d9f1d
Compare
graphite-app
bot
force-pushed
the
11-05-perf_linter_plugins_small_optimizations_to_scopemanager_
branch
from
13cf9c4 to
8b31daa
Compare
Base automatically changed from
11-05-docs_linter_plugins_reformat_and_clarify_scopemanager_jsdoc_comments
to
main
November 5, 2025 16:31
graphite-app
bot
deleted the
11-05-perf_linter_plugins_small_optimizations_to_scopemanager_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #14890. Small optimizations to
ScopeManager.=== nullor=== undefinedinstead of!.Also add comments about potential future optimizations.