Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 5, 2025

Fix TS type defs. Add parent property to FormalParameterRest and TSParameterProperty, which both have their type definitions defined manually.

Copy link
Member Author

overlookmotel commented Nov 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 5, 2025

CodSpeed Performance Report

Merging #15337 will not alter performance

Comparing 11-05-fix_linter_plugins_napi_parser_add_parent_field_to_formalparameterrest_and_tsparameterproperty_in_ts_type_defs (7ee1de4) with main (b5d6360)1

Summary

✅ 37 untouched

Footnotes

  1. No successful run was found on 11-05-fix_linter_plugins_make_parent_fields_in_ts_type_defs_non-optional (5d7c505) during the generation of this report, so main (b5d6360) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review November 5, 2025 15:44
@overlookmotel overlookmotel force-pushed the 11-05-fix_linter_plugins_napi_parser_add_parent_field_to_formalparameterrest_and_tsparameterproperty_in_ts_type_defs branch from 049398b to b922b51 Compare November 5, 2025 16:09
@overlookmotel overlookmotel force-pushed the 11-05-fix_linter_plugins_make_parent_fields_in_ts_type_defs_non-optional branch 2 times, most recently from 3d24cf8 to 5d7c505 Compare November 5, 2025 16:11
@overlookmotel overlookmotel force-pushed the 11-05-fix_linter_plugins_napi_parser_add_parent_field_to_formalparameterrest_and_tsparameterproperty_in_ts_type_defs branch from b922b51 to 7ee1de4 Compare November 5, 2025 16:11
@overlookmotel overlookmotel self-assigned this Nov 5, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
Copy link
Member Author

overlookmotel commented Nov 5, 2025

Merge activity

…terRest` and `TSParameterProperty` in TS type defs (#15337)

Fix TS type defs. Add `parent` property to `FormalParameterRest` and `TSParameterProperty`, which both have their type definitions defined manually.
@graphite-app graphite-app bot force-pushed the 11-05-fix_linter_plugins_make_parent_fields_in_ts_type_defs_non-optional branch from 5d7c505 to 861508a Compare November 5, 2025 16:26
@graphite-app graphite-app bot force-pushed the 11-05-fix_linter_plugins_napi_parser_add_parent_field_to_formalparameterrest_and_tsparameterproperty_in_ts_type_defs branch from 7ee1de4 to 40231a6 Compare November 5, 2025 16:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 5, 2025
Base automatically changed from 11-05-fix_linter_plugins_make_parent_fields_in_ts_type_defs_non-optional to main November 5, 2025 16:33
@graphite-app graphite-app bot merged commit 40231a6 into main Nov 5, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-05-fix_linter_plugins_napi_parser_add_parent_field_to_formalparameterrest_and_tsparameterproperty_in_ts_type_defs branch November 5, 2025 16:33
@Boshen Boshen mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-cli Area - CLI A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants