-
-
Notifications
You must be signed in to change notification settings - Fork 720
fix(linter/plugins): allow access to cwd in createOnce in ESLint interop mode
#15488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter/plugins): allow access to cwd in createOnce in ESLint interop mode
#15488
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds ESLint compatibility support for the createOnce API by implementing a shim FILE_CONTEXT object in index.ts that mirrors the main implementation. The shim provides limited context functionality (only cwd property and extend method) available during createOnce calls, while throwing errors for other properties that should not be accessed at that stage.
- Exports
FileContexttype fromcontext.tsfor reuse inindex.ts - Implements a
FILE_CONTEXTshim inindex.tsfor ESLint compatibility - Updates
createContextAndVisitorto use the newFILE_CONTEXTas prototype
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/context.ts | Exports FileContext type and adds a comment noting the need to sync getCwd implementation with the ESLint shim |
| apps/oxlint/src-js/index.ts | Adds ESLint-compatible FILE_CONTEXT shim for createOnce calls, imports necessary types, and updates createContextAndVisitor to use the new prototype |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
24b5f8e to
ee9287b
Compare
Merge activity
|
ee9287b to
7409630
Compare

#15301 made
Context#cwdavailable increateOnce. Make it available in ESLint compat mode too. Ditto theextendmethod added in #15477.Define all other
Contextmethods/getters on prototype ofContextin ESLint compat mode, for completeness.