Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast)!: rename visit_arrow_expression to visit_arrow_function_expression. #3995

Conversation

rzvxa
Copy link
Collaborator

@rzvxa rzvxa commented Jul 1, 2024

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-ast Area - AST A-isolated-declarations Isolated Declarations labels Jul 1, 2024
Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #3995 will not alter performance

Comparing 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ (c98d8aa) with main (1dacb1f)

Summary

✅ 28 untouched benchmarks

@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 14:48
@rzvxa rzvxa changed the title refactor(ast): rename arrow_expression to arrow_function_expression. refactor(ast): rename visit_arrow_expression to visit_arrow_function_expression. Jul 1, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2024 — with Graphite App
Copy link

graphite-app bot commented Jul 1, 2024

Merge activity

  • Jul 1, 12:03 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 1, 12:04 PM EDT: Boshen removed this pull request from the Graphite merge queue.
  • Jul 1, 12:04 PM EDT: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jul 1, 12:05 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 9:52 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 9:52 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 2, 5:18 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 2, 5:25 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-01-refactor_ast_reorder_fields_to_reflect_their_visit_order branch from e4f27b3 to 0fe22a8 Compare July 1, 2024 16:10
@Boshen Boshen changed the base branch from 07-01-refactor_ast_reorder_fields_to_reflect_their_visit_order to main July 1, 2024 16:14
@Boshen Boshen force-pushed the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch from 5266b2d to 5f5fc2b Compare July 1, 2024 16:14
@rzvxa rzvxa changed the title refactor(ast): rename visit_arrow_expression to visit_arrow_function_expression. refactor(ast)!: rename visit_arrow_expression to visit_arrow_function_expression. Jul 1, 2024
@Boshen
Copy link
Member

Boshen commented Jul 2, 2024

cargo fmt failed 😢

@rzvxa rzvxa force-pushed the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch from cf3cc16 to 3f02922 Compare July 2, 2024 09:03
@Boshen Boshen force-pushed the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch from 3f02922 to c98d8aa Compare July 2, 2024 09:20
@graphite-app graphite-app bot merged commit c98d8aa into main Jul 2, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch July 2, 2024 09:25
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Boshen added a commit that referenced this pull request Jul 2, 2024
## [0.6.0] - 2024-07-02

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- dc6d45e ast,codegen: Add `TSParenthesizedType` and print type
parentheses correctly (#3979) (Boshen)
- b257d53 linter: Support report
`@typescript-eslint/consistent-type-imports` (#3895) (mysteryven)
- 2114475 linter: Implement @typescript-eslint/no-dynamic-delete (#3971)
(kaykdm)
- 10a3c9a linter/eslint-plugin-react: Implement no-set-state (#3975)
(Jelle van der Waa)

### Bug Fixes

- 432d6d9 linter: Find disabled directives using the message's `Span`.
(#4010) (rzvxa)
- dbbb6fc linter: Global variable check should always check builtin
variables (#3973) (Boshen)

### Performance

- 1eac3d2 semantic: Use `Atom<'a>` for `Reference`s (#3972) (Don Isaac)

### Refactor

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Boshen added a commit that referenced this pull request Jul 5, 2024
## [0.17.0] - 2024-07-05

- e32b4bc ast: [**BREAKING**] Store trivia comments in a sorted slice
(#4045) (Luca Bruno)

- 1df6ac0 ast: [**BREAKING**] Rename `visit_enum_memeber` to
`visit_ts_enum_member`. (#4000) (rzvxa)

- 4a0eaa0 ast: [**BREAKING**] Rename `visit_enum` to
`visit_ts_enum_declaration`. (#3998) (rzvxa)

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- 1854a52 ast_codegen: Introduce the `#[span]` hint. (#4012) (rzvxa)
- 7538af1 ast_codegen: Add visit generator (#3954) (rzvxa)
- 7768d23 isolated-declarations: Support optional class methods (#4035)
(Egor Blinov)
- 0da9dfb minifier: Add constant folding to remove dead code (#4058)
(Boshen)

### Bug Fixes

- aaac2d8 codegen: Preserve parentheses from AST instead calculating
from operator precedence (#4055) (Boshen)
- 5e5b1b1 codegen: Correct accessibility emit for class
formal-parameters/methods/properties (#4042) (Egor Blinov)
- 7844734 codegen: Missing const keyword in TSTypeParamter (#4022)
(Dunqing)
- 6254a41 codegen: Missing TypeParamters in TSCallSignature (#4021)
(Dunqing)
- 3d29e9c isolated-declarations: Eliminate imports incorrectly when they
are used in `TSInferType` (#4043) (Dunqing)
- 02ea19a isolated-declarations: Should emit `export {}` when only
having `ImportDeclaration` (#4026) (Dunqing)
- 7c915f4 isolated-declarations: Binding elements with export should
report an error (#4025) (Dunqing)
- 05a047c isolated-declarations: Method following an abstract method
gets dropped (#4024) (Dunqing)
- c043bec isolated_declarations: Add mapped-type constraint to the scope
(#4037) (Egor Blinov)
- b007553 isolated_declarations: Fix readonly specifier on class
constructor params (#4030) (Egor Blinov)
- da62839 isolated_declarations: Inferring literal types for readonly
class fileds (#4027) (Egor Blinov)

### Refactor

- b51f75b ast_codegen: No longer outputs discard variable for empty
visitors. (#4008) (rzvxa)
- edb557c minifier: Add a folder struct for constant folding (#4057)
(Boshen)
- 243c9f3 parser: Use function instead of trait to parse list with rest
element (#4028) (Boshen)
- 1dacb1f parser: Use function instead of trait to parse delimited lists
(#4014) (Boshen)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-isolated-declarations Isolated Declarations A-linter Area - Linter A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants