Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ast)!: rename visit_enum to visit_ts_enum_declaration. #3998

Merged
merged 1 commit into from
Jul 2, 2024
Merged

refactor(ast)!: rename visit_enum to visit_ts_enum_declaration. #3998

merged 1 commit into from
Jul 2, 2024

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 1, 2024

No description provided.

This was referenced Jul 1, 2024
Merged
Merged
@rzvxa Graphite App
Copy link
Contributor Author

rzvxa commented Jul 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on Graphite Graphite

@rzvxa rzvxa mentioned this pull request Jul 1, 2024
Merged
@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Jul 1, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3998 will not alter performance

Comparing 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ (4a0eaa0) with main (c98d8aa)

Summary

✅ 28 untouched benchmarks

This was referenced Jul 1, 2024
Merged
Merged
@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 14:48
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 1, 2024 — with Graphite App
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 1, 2024 •
edited
Loading

Merge activity

  • Jul 1, 12:03 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 1, 12:03 PM EDT: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Jul 1, 12:04 PM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #3995.
  • Jul 1, 12:05 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 1, 9:52 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 2, 5:18 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Jul 2, 5:26 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Format').
  • Jul 2, 5:55 AM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 2, 5:55 AM EDT: rzvxa added this pull request to the Graphite merge queue.
  • Jul 2, 6:05 AM EDT: rzvxa merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch from 5266b2d to 5f5fc2b Compare July 1, 2024 16:14
@Boshen Boshen force-pushed the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch from a26fc93 to 9f38f5e Compare July 1, 2024 16:15
@rzvxa rzvxa force-pushed the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch from 9f38f5e to 1835fec Compare July 1, 2024 16:43
@rzvxa rzvxa changed the title refactor(ast): rename visit_enum to visit_ts_enum_declaration. refactor(ast)!: rename visit_enum to visit_ts_enum_declaration. Jul 1, 2024
This was referenced Jul 1, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@rzvxa rzvxa force-pushed the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch 2 times, most recently from 60a7b71 to a741772 Compare July 2, 2024 08:59
@rzvxa rzvxa force-pushed the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch from cf3cc16 to 3f02922 Compare July 2, 2024 09:03
@rzvxa rzvxa force-pushed the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch from a741772 to 165e5fc Compare July 2, 2024 09:03
@Boshen Boshen force-pushed the 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ branch from 3f02922 to c98d8aa Compare July 2, 2024 09:20
Boshen pushed a commit that referenced this pull request Jul 2, 2024
@rzvxa
refactor(ast)!: rename visit_enum to visit_ts_enum_declaration. (#…
18e8a03 
…3998)
@Boshen Boshen force-pushed the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch from 165e5fc to 18e8a03 Compare July 2, 2024 09:20
@Boshen Boshen changed the base branch from 07-01-refactor_ast_rename_arrow_expression_to_arrow_function_expression_ to main July 2, 2024 09:25
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jul 2, 2024
@rzvxa
Copy link
Contributor Author

rzvxa commented Jul 2, 2024

I don't get why these formatting issues pop up after merging the down stack, I'll fix it and let you know.

@rzvxa rzvxa added the 0-merge Merge with Graphite Merge Queue label Jul 2, 2024
@rzvxa rzvxa force-pushed the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch from b82c2b5 to 4a0eaa0 Compare July 2, 2024 09:56
@graphite-app graphite-app bot merged commit 4a0eaa0 into main Jul 2, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 07-01-refactor_ast_rename_visit_enum_to_visit_ts_enum_declaration_ branch July 2, 2024 10:05
@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Merged
Boshen added a commit that referenced this pull request Jul 5, 2024
@github-actions @Boshen
Release crates v0.17.0 (#4059)
224f5ef 
## [0.17.0] - 2024-07-05

- e32b4bc ast: [**BREAKING**] Store trivia comments in a sorted slice
(#4045) (Luca Bruno)

- 1df6ac0 ast: [**BREAKING**] Rename `visit_enum_memeber` to
`visit_ts_enum_member`. (#4000) (rzvxa)

- 4a0eaa0 ast: [**BREAKING**] Rename `visit_enum` to
`visit_ts_enum_declaration`. (#3998) (rzvxa)

- c98d8aa ast: [**BREAKING**] Rename `visit_arrow_expression` to
`visit_arrow_function_expression`. (#3995) (rzvxa)

### Features

- 1854a52 ast_codegen: Introduce the `#[span]` hint. (#4012) (rzvxa)
- 7538af1 ast_codegen: Add visit generator (#3954) (rzvxa)
- 7768d23 isolated-declarations: Support optional class methods (#4035)
(Egor Blinov)
- 0da9dfb minifier: Add constant folding to remove dead code (#4058)
(Boshen)

### Bug Fixes

- aaac2d8 codegen: Preserve parentheses from AST instead calculating
from operator precedence (#4055) (Boshen)
- 5e5b1b1 codegen: Correct accessibility emit for class
formal-parameters/methods/properties (#4042) (Egor Blinov)
- 7844734 codegen: Missing const keyword in TSTypeParamter (#4022)
(Dunqing)
- 6254a41 codegen: Missing TypeParamters in TSCallSignature (#4021)
(Dunqing)
- 3d29e9c isolated-declarations: Eliminate imports incorrectly when they
are used in `TSInferType` (#4043) (Dunqing)
- 02ea19a isolated-declarations: Should emit `export {}` when only
having `ImportDeclaration` (#4026) (Dunqing)
- 7c915f4 isolated-declarations: Binding elements with export should
report an error (#4025) (Dunqing)
- 05a047c isolated-declarations: Method following an abstract method
gets dropped (#4024) (Dunqing)
- c043bec isolated_declarations: Add mapped-type constraint to the scope
(#4037) (Egor Blinov)
- b007553 isolated_declarations: Fix readonly specifier on class
constructor params (#4030) (Egor Blinov)
- da62839 isolated_declarations: Inferring literal types for readonly
class fileds (#4027) (Egor Blinov)

### Refactor

- b51f75b ast_codegen: No longer outputs discard variable for empty
visitors. (#4008) (rzvxa)
- edb557c minifier: Add a folder struct for constant folding (#4057)
(Boshen)
- 243c9f3 parser: Use function instead of trait to parse list with rest
element (#4028) (Boshen)
- 1dacb1f parser: Use function instead of trait to parse delimited lists
(#4014) (Boshen)

Co-authored-by: Boshen <Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzvxa @Boshen