Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(ast): generate visit_mut.rs. #4007

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

rzvxa
Copy link
Contributor

@rzvxa rzvxa commented Jul 1, 2024

No description provided.

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler labels Jul 1, 2024
@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 19:01
Copy link

codspeed-hq bot commented Jul 1, 2024

CodSpeed Performance Report

Merging #4007 will degrade performances by 13.79%

Comparing 07-01-improvement_ast_generate_visit_mut.rs_ (cd1e9bd) with 07-01-feat_ast_codegen_support_for_generating_visitmut_ (272df6e)

Summary

❌ 4 regressions
✅ 24 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark 07-01-feat_ast_codegen_support_for_generating_visitmut_ 07-01-improvement_ast_generate_visit_mut.rs_ Change
minifier[react.development.js] 1.6 ms 1.8 ms -7.06%
minifier[typescript.js] 262 ms 280 ms -6.42%
prepass[react.development.js] 198.7 µs 230.5 µs -13.79%
prepass[typescript.js] 26.2 ms 30.1 ms -13.07%

@rzvxa rzvxa marked this pull request as draft July 1, 2024 19:03
@rzvxa rzvxa marked this pull request as ready for review July 1, 2024 19:05
@rzvxa rzvxa force-pushed the 07-01-feat_ast_codegen_support_for_generating_visitmut_ branch from 3d1bec8 to b5e37e8 Compare July 2, 2024 08:56
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_visit_mut.rs_ branch from d0714b3 to 8523957 Compare July 2, 2024 08:56
@rzvxa rzvxa force-pushed the 07-01-feat_ast_codegen_support_for_generating_visitmut_ branch from b5e37e8 to 51bfe86 Compare July 2, 2024 09:00
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_visit_mut.rs_ branch from 8523957 to 7157edf Compare July 2, 2024 09:00
@rzvxa rzvxa force-pushed the 07-01-feat_ast_codegen_support_for_generating_visitmut_ branch from 51bfe86 to 6b018dc Compare July 2, 2024 09:04
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_visit_mut.rs_ branch from 7157edf to d3a1b2d Compare July 2, 2024 09:04
@rzvxa rzvxa force-pushed the 07-01-feat_ast_codegen_support_for_generating_visitmut_ branch from 6b018dc to a661a98 Compare July 2, 2024 09:52
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_visit_mut.rs_ branch from d3a1b2d to bd20e86 Compare July 2, 2024 09:52
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jul 2, 2024 — with Graphite App
@rzvxa rzvxa force-pushed the 07-01-feat_ast_codegen_support_for_generating_visitmut_ branch from a661a98 to 45add96 Compare July 2, 2024 10:07
@rzvxa rzvxa force-pushed the 07-01-improvement_ast_generate_visit_mut.rs_ branch from bd20e86 to 1655e47 Compare July 2, 2024 10:08
Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

@Boshen Boshen force-pushed the 07-01-feat_ast_codegen_support_for_generating_visitmut_ branch from 45add96 to 272df6e Compare July 2, 2024 10:20
@Boshen Boshen force-pushed the 07-01-improvement_ast_generate_visit_mut.rs_ branch from 1655e47 to cd1e9bd Compare July 2, 2024 10:20
@Boshen Boshen changed the base branch from 07-01-feat_ast_codegen_support_for_generating_visitmut_ to main July 2, 2024 10:42
@graphite-app graphite-app bot merged commit cd1e9bd into main Jul 2, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 07-01-improvement_ast_generate_visit_mut.rs_ branch July 2, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants