refactor(transformer/typescript): insert assignments after super by `StatementInjector` #6654

Dunqing · 2024-10-18T07:21:18Z

No description provided.

graphite-app · 2024-10-18T07:21:23Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Dunqing · 2024-10-18T07:21:25Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

codspeed-hq · 2024-10-18T07:31:13Z

CodSpeed Performance Report

Merging #6654 will not alter performance

_{Comparing 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector (a19027f) with main (b711ee1)}

Summary

✅ 30 untouched benchmarks

overlookmotel · 2024-10-21T11:17:46Z

Nice!

Dunqing · 2024-10-21T11:38:07Z

Nice!

Why I can't see the performance improvement in this PR

crates/oxc_transformer/src/typescript/annotations.rs

Dunqing · 2024-10-24T05:12:39Z

Just a tiny refactor, so I am going to merge it without approvement

Dunqing · 2024-10-24T05:13:46Z

Merge activity

Oct 24, 1:13 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 24, 1:14 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 24, 1:19 AM EDT: A user merged this pull request with the Graphite merge queue.

…StatementInjector` (#6654)

…ke an iterator (#6856) Follow-on after #6654. Taking an `IntoIterator` avoids caller needing to construct a temporary `Vec`.

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen) - 686727f minifier: Reference read has side effect (#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (#6848) (Dunqing) - b075982 types: Change @oxc/types package name (#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (#6890) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

…ke an iterator (oxc-project#6856) Follow-on after oxc-project#6654. Taking an `IntoIterator` avoids caller needing to construct a temporary `Vec`.

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (oxc-project#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (oxc-project#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (oxc-project#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (oxc-project#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (oxc-project#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (oxc-project#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (oxc-project#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (oxc-project#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (oxc-project#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (oxc-project#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (oxc-project#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (oxc-project#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (oxc-project#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (oxc-project#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen) - 686727f minifier: Reference read has side effect (oxc-project#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (oxc-project#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (oxc-project#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (oxc-project#6848) (Dunqing) - b075982 types: Change @oxc/types package name (oxc-project#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (oxc-project#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (oxc-project#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (oxc-project#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (oxc-project#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (oxc-project#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (oxc-project#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (oxc-project#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (oxc-project#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (oxc-project#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (oxc-project#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (oxc-project#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (oxc-project#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (oxc-project#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (oxc-project#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (oxc-project#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (oxc-project#6890) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Dunqing mentioned this pull request Oct 18, 2024

feat(ast): add GetAddress trait #6652

Merged

Dunqing mentioned this pull request Oct 18, 2024

feat(transformer): introduce StatementInjector helper #6653

Merged

Dunqing changed the title ~~refactor(transformer/typescript): insert assignments after super by StatementInjector~~ refactor(transformer/typescript): insert assignments after super by StatementInjector Oct 18, 2024

Dunqing requested a review from overlookmotel October 18, 2024 07:22

github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 18, 2024

overlookmotel force-pushed the 10-18-feat_transformer_introduce_statementinjector_helper branch from b170471 to 2270e72 Compare October 21, 2024 10:51

overlookmotel force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from ca8c578 to 2b616a1 Compare October 21, 2024 10:52

Dunqing force-pushed the 10-18-feat_transformer_introduce_statementinjector_helper branch from b051f24 to 7fbca9d Compare October 21, 2024 11:00

Base automatically changed from 10-18-feat_transformer_introduce_statementinjector_helper to main October 21, 2024 11:04

Dunqing force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch 2 times, most recently from 3e01750 to e51e2fe Compare October 21, 2024 11:11

Dunqing commented Oct 21, 2024

View reviewed changes

crates/oxc_transformer/src/typescript/annotations.rs Show resolved Hide resolved

Boshen marked this pull request as ready for review October 22, 2024 09:41

overlookmotel mentioned this pull request Oct 22, 2024

feat(transformer): complete the async-to-generator plugin #6658

Merged

Dunqing force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from 38df391 to 1a894aa Compare October 22, 2024 13:38

Dunqing changed the base branch from main to 10-22-fix_transformer_after_using_statementinjector_some_statements_disappeared October 22, 2024 13:38

Dunqing mentioned this pull request Oct 22, 2024

fix(transformer): after using StatementInjector, some statements disappeared #6778

Merged

overlookmotel changed the base branch from 10-22-fix_transformer_after_using_statementinjector_some_statements_disappeared to graphite-base/6654 October 22, 2024 14:10

overlookmotel force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from 1a894aa to 03f0cf2 Compare October 22, 2024 14:14

overlookmotel force-pushed the graphite-base/6654 branch from 2c49d9c to b711ee1 Compare October 22, 2024 14:14

overlookmotel changed the base branch from graphite-base/6654 to main October 22, 2024 14:15

overlookmotel force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from 03f0cf2 to a19027f Compare October 22, 2024 14:15

Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 24, 2024

refactor(transformer/typescript): insert assignments after super by `…

3a56d59

…StatementInjector` (#6654)

Dunqing force-pushed the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch from a19027f to 3a56d59 Compare October 24, 2024 05:14

graphite-app bot merged commit 3a56d59 into main Oct 24, 2024
26 checks passed

graphite-app bot deleted the 10-18-refactor_transformer_typescript_insert_assignments_after_super_by_statementinjector branch October 24, 2024 05:19

overlookmotel mentioned this pull request Oct 24, 2024

refactor(transformer): StatementInjectorStore::insert_many_after take an iterator #6856

Merged

Dunqing pushed a commit that referenced this pull request Oct 24, 2024

refactor(transformer): StatementInjectorStore::insert_many_after ta…

7339dde

…ke an iterator (#6856) Follow-on after #6654. Taking an `IntoIterator` avoids caller needing to construct a temporary `Vec`.

oxc-bot mentioned this pull request Oct 26, 2024

release(crates): v0.34.0 #6908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(transformer/typescript): insert assignments after super by `StatementInjector` #6654

refactor(transformer/typescript): insert assignments after super by `StatementInjector` #6654

Dunqing commented Oct 18, 2024

graphite-app bot commented Oct 18, 2024

Dunqing commented Oct 18, 2024 •

edited

Loading

codspeed-hq bot commented Oct 18, 2024 •

edited

Loading

overlookmotel commented Oct 21, 2024

Dunqing commented Oct 21, 2024

Dunqing commented Oct 24, 2024

Dunqing commented Oct 24, 2024 •

edited by graphite-app bot

Loading

refactor(transformer/typescript): insert assignments after super by StatementInjector #6654

refactor(transformer/typescript): insert assignments after super by StatementInjector #6654

Conversation

Dunqing commented Oct 18, 2024

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Dunqing commented Oct 18, 2024 • edited Loading

codspeed-hq bot commented Oct 18, 2024 • edited Loading

CodSpeed Performance Report

Merging #6654 will not alter performance

Summary

overlookmotel commented Oct 21, 2024

Dunqing commented Oct 21, 2024

Dunqing commented Oct 24, 2024

Dunqing commented Oct 24, 2024 • edited by graphite-app bot Loading

Merge activity

refactor(transformer/typescript): insert assignments after super by `StatementInjector` #6654

refactor(transformer/typescript): insert assignments after super by `StatementInjector` #6654

Dunqing commented Oct 18, 2024 •

edited

Loading

codspeed-hq bot commented Oct 18, 2024 •

edited

Loading

Dunqing commented Oct 24, 2024 •

edited by graphite-app bot

Loading