feat(transformer): complete the async-to-generator plugin

[Dunqing]

In this PR, most of the async functions have transformed correctly. But the async arrow functions don't fully transform correctly yet, it is related to we need to transform the arrow function to the generator function. For example:

Input:

function declaration() {
  const asy = async () => {
  console.log(this.name)
 }
}

Output:

function declaration() {
  const asy = babelHelpers.asyncToGenerator(function* () {
     console.log(this.name);
  });
}

Expected Output:

function declaration() {
  var _this = this;
  const asy = /*#__PURE__*/function () {
    var _ref = babelHelpers.asyncToGenerator(function* () {
      console.log(_this.name);
    });
    return function asy() {
      return _ref.apply(this, arguments);
    };
  }();
}

From the expected output, we haven't handled this correctly, which means even if the arrow-function plugin doesn't enable, we still need to handle this correctly as the arrow-function plugin does, and further question if arrow-function plugin is enabled, how to avoid these making conflict?

I thought we may move out the implementation of arrow-function and as a common helper, this way every plugin can handle this well

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• feat(transformer): complete the async-to-generator plugin #6658 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6658 will degrade performances by 6.29%

_{Comparing 10-18-feat_transformer_async-to-generator_transform_functions_and_arrow_functions_which_have_no_id_and_no_arguments (0d0bb17) with main (90c786c)}

Summary

❌ 1 regressions
✅ 29 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	main	10-18-feat_transformer_async-to-generator_transform_functions_and_arrow_functions_which_have_no_id_and_no_arguments	Change
❌	transformer[cal.com.tsx]	30.7 ms	32.8 ms	-6.29%

[overlookmotel]

Oh I'm sorry. #6856 or #6858 has caused merge conflicts and likely broken things. I should have reviewed and merged this PR first.

[overlookmotel]

I've not reviewed the logic of this transform, as I don't know it well enough. But this PR makes the tests pass so 👍!

All my comments are style nits, and some notes about use of #[inline]. I hope that's useful, and not annoying!

[Dunqing]

Mering this!

[Dunqing]

Merge activity

• Oct 24, 11:18 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 24, 11:18 PM EDT: A user added this pull request to the Graphite merge queue.
• Oct 24, 11:27 PM EDT: A user merged this pull request with the Graphite merge queue.