refactor(traverse): move generate_binding to TraverseScoping

[overlookmotel]

Follow-up after #6830.

Now that generate_binding doesn't need access to AstBuilder, it can move into TraverseScoping.

Occasionally this is helpful when you need to borrows 2 parts of TraverseCtx simultaneously. e.g.:

// This fails to compile because we try to mutably borrow `TraverseCtx`
// while it's already borrowed
if let Ancestor::ProgramBody(body) = ctx.parent() {
    //                               ^^^ immutable borrow
    let binding = ctx.generate_binding(name, scope_id, flags);
    //            ^^^ mutable borrow
}

// Borrow-checker allows this because we borrow fields of `TraverseCtx` separately
if let Ancestor::ProgramBody(body) = ctx.ancestry.parent() {
    let binding = ctx.scoping.generate_binding(name, scope_id, flags);
}

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

• refactor(traverse): rename TraverseScoping::generate_binding_in_current_scope #6832
• refactor(traverse): move generate_binding to TraverseScoping #6831 👈
• refactor(traverse): TraverseCtx::generate_binding take an Atom #6830
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6831 will not alter performance

_{Comparing 10-23-refactor_traverse_move_generate_binding_to_traversescoping_ (5bf0a49) with 10-23-refactor_traverse_traversectx_generate_binding_take_an_atom_ (9b33fca)}

Summary

✅ 30 untouched benchmarks

[Dunqing]

I just found out we can use ctx.scoping.

[graphite-app]

Merge activity

• Oct 24, 2:19 AM EDT: A user added this pull request to the Graphite merge queue.
• Oct 24, 2:24 AM EDT: A user merged this pull request with the Graphite merge queue.