Create Floating IPs and attach them to instances

[charliepark]

This PR adds the ability in the web console to create / attach / detach / delete Floating IPs. As the API doesn't currently have an update endpoint for Floating IPs, that's outside the scope of this PR.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Feb 23, 2024 1:05am

[david-crespo]

This is looking great. A few things remaining for me. Some could be done in followups so we can get this merged and work more incrementally:

• Floating IPs should be returned by mock instanceExternalIpList #1966

• List floating IPs more clearly on single instance page #1965 (more of a separate thing, not really fixing anything here, but worth mentioning)

• I personally prefer having only detach or attach in a given set of actions at a time. I think it's clear enough what they means (and we explain, or should explain, the action in the modal that pops up) and it saves us from having to write out this disabled copy. I think only having one or the other helps the user see them (correctly) as a sort of toggle on and toggle off rather than two parallel actions.

  

• Info box in the attach modal explaining what this action does

  

• @benjaminleonard and @paryhin taking a look at what we did with the advanced accordion on floating IP create. Copy could also use a second look

  

[david-crespo]

The whole attachModalOpen state variable is unnecessary as you can use whether floatingIpToModify is present to mean the same thing. So here you could just do setFloatingIpToModify(null) instead, and get rid of all the other references to attachModalOpen. Here's another spot where we do this:

console/app/pages/project/networking/VpcPage/tabs/VpcSubnetsTab.tsx

Line 25 in 5d989a7

const [editing, setEditing] = useState<VpcSubnet | null>(null)

[david-crespo]

One more small thing but it's ready to go!